Skip to content

Escape backticks #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 26, 2021
Merged

Escape backticks #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ef9ba90
Add test
inokawa Jun 26, 2021
633f956
Add test
inokawa Jun 26, 2021
d9eab97
Fix test
inokawa Jun 26, 2021
7e36786
Escape backticks in js
inokawa Jun 26, 2021
53e6362
Fix test
inokawa Jun 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions fixtures/app-export-default-with-backticks.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import React from "react";
import { webViewRender } from "react-native-react-bridge/lib/web";
import Comp from "./Component";
import "./example.css";

const text = "foo `bar`";
console.log(text);
console.log(`baz`);

const App = () => {
return <Comp />;
};

export default webViewRender(App);
27 changes: 0 additions & 27 deletions src/plugin/__snapshots__/html.spec.js.snap
View file
Open in desktop

This file was deleted.

3,572 changes: 3,572 additions & 0 deletions src/plugin/__snapshots__/index.spec.js.snap
View file
Open in desktop

Large diffs are not rendered by default.

20 changes: 20 additions & 0 deletions src/plugin/__snapshots__/metro.spec.js.snap
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 3 additions & 1 deletion src/plugin/html.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
import { ROOT_ID } from "../common";

const escape = (src) => src.replace(/`/g, "\\`");

export const createContent = (js) =>
`export default String.raw\`${wrapByHtml(js)}\`;`;
`export default String.raw\`${escape(wrapByHtml(js))}\`;`;

const wrapByHtml = (js) => `
<!DOCTYPE html>
Expand Down
14 changes: 0 additions & 14 deletions src/plugin/html.spec.js
View file
Open in desktop

This file was deleted.

36 changes: 36 additions & 0 deletions src/plugin/index.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
import * as fs from "fs";
import * as path from "path";
import { transform } from "./";

const createPath = (filename) =>
path.join(__dirname, "../../fixtures", filename);
const readFixture = (filename) => fs.readFileSync(filename, "utf-8");

describe("transform", () => {
it("export default", async () => {
const filename = "app-export-default.jsx";
const filePath = createPath(filename);
const src = readFixture(filePath);
expect(
await transform({ filename: filePath, src, options: {} })
).toMatchSnapshot();
});

it("export default with backticks", async () => {
const filename = "app-export-default-with-backticks.jsx";
const filePath = createPath(filename);
const src = readFixture(filePath);
expect(
await transform({ filename: filePath, src, options: {} })
).toMatchSnapshot();
});

it("export default with md", async () => {
const filename = "app-export-default-with-md.jsx";
const filePath = createPath(filename);
const src = readFixture(filePath);
expect(
await transform({ filename: filePath, src, options: {} })
).toMatchSnapshot();
});
});
7 changes: 7 additions & 0 deletions src/plugin/metro.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,13 @@ describe("bundle", () => {
expect(res).toMatchSnapshot();
});

it("with backticks", async () => {
const filename = "app-export-default-with-backticks.jsx";
const filePath = resolvePath(filename);
const res = await bundle(filePath);
expect(res).toMatchSnapshot();
});

it("default (preact)", async () => {
const filename = "app-export-default-preact.jsx";
const filePath = resolvePath(filename);
Expand Down