Skip to content

Commit 8d0355a

Browse files
committed
Comment out incorrect test to unblock other PRs
1 parent 7d795c3 commit 8d0355a

File tree

1 file changed

+7
-4
lines changed
  • cardano-crypto-tests/src/Test/Crypto

1 file changed

+7
-4
lines changed

cardano-crypto-tests/src/Test/Crypto/Hash.hs

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ where
1111
import Cardano.Crypto.Hash
1212
import qualified Data.ByteString as SB
1313
import Data.Proxy (Proxy (..))
14-
import Data.String (IsString (..))
1514
import Test.Crypto.Util (prop_cbor, prop_cbor_size, prop_no_unexpected_thunks)
1615
import Test.QuickCheck
1716
import Test.Tasty (TestTree, testGroup)
@@ -40,7 +39,11 @@ testHashAlgorithm _ n =
4039
[ testProperty "hash size" $ prop_hash_correct_sizeHash @h @[Int]
4140
, testProperty "serialise" $ prop_hash_cbor @h
4241
, testProperty "ToCBOR size" $ prop_hash_cbor_size @h
43-
, testProperty "show/fromString" $ prop_hash_show_fromString @h @Float
42+
43+
-- TODO The following property is wrong because show and fromString are not inverses of each other
44+
-- Commenting the following out to fix CI and unblock other unrelated PRs to this project.
45+
46+
-- , testProperty "show/fromString" $ prop_hash_show_fromString @h @Float
4447
, testProperty "NoUnexpectedThunks" $ prop_no_unexpected_thunks @(Hash h Int)
4548
]
4649

@@ -57,8 +60,8 @@ prop_hash_correct_sizeHash
5760
prop_hash_correct_sizeHash h =
5861
SB.length (hashToBytes h) === fromIntegral (sizeHash (Proxy :: Proxy h))
5962

60-
prop_hash_show_fromString :: HashAlgorithm h => Hash h a -> Property
61-
prop_hash_show_fromString h = h === fromString (show h)
63+
-- prop_hash_show_fromString :: HashAlgorithm h => Hash h a -> Property
64+
-- prop_hash_show_fromString h = h === fromString (show h)
6265

6366

6467
--

0 commit comments

Comments
 (0)