Cache for tables that are reused frequently #1074
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
tmcgilchrist
reviewed
Apr 1, 2022
| case byronBlockRaw blk of | ||
| Byron.ABOBBlock ablk -> insertABlock tracer cache firstBlockOfEpoch ablk details | ||
| Byron.ABOBBoundary abblk -> insertABOBBoundary tracer cache abblk details | ||
| -- Serializiing things during syncing can drastically slow down full sync |
There was a problem hiding this comment.
Suggested change
| -- Serializiing things during syncing can drastically slow down full sync | |
| -- Serializing things during syncing can drastically slow down full sync |
tmcgilchrist
reviewed
Apr 1, 2022
|
|
||
| import qualified Cardano.Db as DB | ||
|
|
||
| import Cardano.DbSync.Cache |
There was a problem hiding this comment.
Suggested change
| import Cardano.DbSync.Cache | |
| import Cardano.DbSync.Cache (Cache(..), uninitiatedCache) |
tmcgilchrist
reviewed
Apr 1, 2022
| SyncLagging -> 2000 | ||
|
|
||
| rightToJust (Right a) = Just a | ||
| rightToJust _ = Nothing |
There was a problem hiding this comment.
There's a version of this in https://hackage.haskell.org/package/either that's already floating around in package deps somewhere.
tmcgilchrist
reviewed
Apr 1, 2022
| Origin -> DB.queryGenesis | ||
| At blk -> DB.queryBlockId (SBS.fromShort . getOneEraHash $ blockPointHash blk) | ||
| Origin -> | ||
| fmap (, Nothing) <$> DB.queryGenesis |
There was a problem hiding this comment.
Suggested change
| fmap (, Nothing) <$> DB.queryGenesis | |
| (, Nothing) <<$>> DB.queryGenesis |
I think there is fmap . fmap defined in Protolude as <<$>>
|
What kind of speedup and memory usage are you seeing before / after this change? |
On benchmarks I've seen some pretty good speedup by caching multiassets #1067 |
Merged
|
Superceeded by PR #1094 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1067