-
Notifications
You must be signed in to change notification settings - Fork 62
[LW-10219] Ledger: Sign new certificate types #1211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
AngelCastilloB
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🚀 , just some requested changes regarding the use of the Transform type to enforce some extra mapping validations
db89d39 to
3e09025
Compare
4f5114e to
f2f491e
Compare
6b744e2 to
bfeebde
Compare
bc756d3 to
14136dd
Compare
AngelCastilloB
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @vetalcore 🥇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vetalcore Amazing stuff 💯
I left just a few minor comments. Could you please take a look?
Also, can you extend these tests https://github.com/input-output-hk/cardano-js-sdk/blob/master/packages/hardware-ledger/test/transformers/tx.test.ts with new cert types? 🙏
ddc6147 to
0f6bc6d
Compare
a69325e to
064558b
Compare
tomislavhoracek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
mchappell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff @vetalcore 🚀
064558b to
2dcc331
Compare
2dcc331 to
ef6ffb4
Compare
|
I re-opened the branch just to run Ledger conway-era tests ( |
Context
Adjust mappers to match new
conway-eracertificates.Proposed Solution
Important Changes Introduced