ci: build Dockerfile in CI without cache #637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible for changes in package dependencies to remove the need for a local `node_modules` directory in `cardano-services`, but our existing workflows will use available cache, which are not invalidated by this scenario. This change ensure at least one build in CI checks we can reliably build the image. Note that omitting the `target` tells the Docker engine to build each stage.
AngelCastilloB
approved these changes
Mar 12, 2023
Member
There was a problem hiding this comment.
Just in case I cloned this branch in a clean VM and tried constructing the docker image (to make sure #626 is indeed no longer reproducible), works perfectly 😎. Being able to detect the error during CI will be useful
mkazlauskas
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
It's possible for changes in package dependencies to remove the need for a local
node_modulesdirectory incardano-services, but our existing workflows will use available cache, which are not invalidated by this scenario.Resolves #626
Proposed Solution
targettells the Docker engine to build each stage.node_modulesmissing #626, as it appears we've since added dependencies that again require the localnode_moduledirectory, as I now seepgandpg-pool, which are non-dev dependencies, so the folder requiresCOPYing