Skip to content

Conversation

@tomislavhoracek
Copy link
Contributor

This PR introduces unit tests for the full transaction which contains all the mapped data constructed with all the possible transformers / mappers from hardware-trezor package

JIRA ticket

@tomislavhoracek tomislavhoracek added chore Administrative task test labels Sep 7, 2023
@tomislavhoracek tomislavhoracek self-assigned this Sep 7, 2023
Copy link
Member

@DominikGuzei DominikGuzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work 🎉

@tomislavhoracek tomislavhoracek removed the request for review from marcin-mazurek September 7, 2023 11:40
@tomislavhoracek
Copy link
Contributor Author

@AngelCastilloB could you review it please?

Copy link
Member

@AngelCastilloB AngelCastilloB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@tomislavhoracek tomislavhoracek merged commit c1f02e8 into chore/lw-6514-hardware-trezor-package Sep 13, 2023
@tomislavhoracek tomislavhoracek deleted the chore/lw-8208-mapped-trezor-tx-unit-test branch September 13, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Administrative task test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants