Skip to content

fix(hardware-trezor): Trezor connect web import LW-6514 #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(hardware-trezor): Trezor connect web import LW-6514 #951

wants to merge 1 commit into from

Conversation

@DominikGuzei
Copy link
Member

@DominikGuzei DominikGuzei commented Oct 17, 2023

Context

This PR fixes an issue related to importing the @trezor/connect-web package. The previous version (seemingly correct) causes an import issue in Lace.

@DominikGuzei DominikGuzei added the bug Something isn't working label Oct 17, 2023
@DominikGuzei DominikGuzei self-assigned this Oct 17, 2023
marcin-mazurek
marcin-mazurek reviewed Oct 17, 2023
View reviewed changes
packages/hardware-trezor/src/TrezorKeyAgent.ts
import { txToTrezor } from './transformers/tx';
import TrezorConnectWeb from '@trezor/connect-web';

const TrezorConnectNode = Trezor.default;
Copy link
Contributor

@marcin-mazurek marcin-mazurek Oct 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why is this weird import style needed? Is it worth leaving a comment?

Copy link
Member Author

@DominikGuzei DominikGuzei Oct 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcin-mazurek no, i think nobody really knows - @mchappell helped me with this because they had the same weird issue with ledger

Copy link
Member

@mkazlauskas mkazlauskas Oct 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should really be equivalent. It indicates that webpack is bundling cjs build rather than esm build. I don't mind merging this, but someone should audit and cleanup lace builds.

@DominikGuzei DominikGuzei mentioned this pull request Oct 17, 2023
Merged
3 tasks
@github-actions
Copy link

github-actions bot commented Oct 17, 2023

Standard DiffPost

This PR would generate the following kubectl diff:

Preview 
diff -u -N /tmp/LIVE-491564489/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-30551269/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-491564489/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend	2023-10-17 13:01:26.816215900 +0000
+++ /tmp/MERGED-30551269/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend	2023-10-17 13:01:26.816215900 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "47"
   creationTimestamp: "2023-08-11T18:16:12Z"
-  generation: 47
+  generation: 48
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: d75c8371d5dac2348583b29b4aaa261a4682fcea
+    app.kubernetes.io/version: 9667d34120e2abc4cc2610b1e7371b4a0a068afe
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
@@ -89,7 +89,7 @@
           value: "false"
         - name: USE_KORA_LABS
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:7scn4gpa4b2v8zgy6icgz01a1y4yjd29
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:3ha727jqjhp77mbnjyvxpsmfsi4zvv2q
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-491564489/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-30551269/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-491564489/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-10-17 13:01:27.020220295 +0000
+++ /tmp/MERGED-30551269/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-10-17 13:01:27.020220295 +0000
@@ -8,7 +8,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: d75c8371d5dac2348583b29b4aaa261a4682fcea
+    app.kubernetes.io/version: 9667d34120e2abc4cc2610b1e7371b4a0a068afe
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-491564489/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector /tmp/MERGED-30551269/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector
--- /tmp/LIVE-491564489/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector	2023-10-17 13:01:27.224224691 +0000
+++ /tmp/MERGED-30551269/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector	2023-10-17 13:01:27.224224691 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "47"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 47
+  generation: 48
   labels:
     app: handle-projector
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: d75c8371d5dac2348583b29b4aaa261a4682fcea
+    app.kubernetes.io/version: 9667d34120e2abc4cc2610b1e7371b4a0a068afe
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-projector
@@ -73,7 +73,7 @@
               name: handle-owner-user.dev-preview-dbsync-db.credentials.postgresql.acid.zalan.do
         - name: PROJECTION_NAMES
           value: handle
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:7scn4gpa4b2v8zgy6icgz01a1y4yjd29
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:3ha727jqjhp77mbnjyvxpsmfsi4zvv2q
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-491564489/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider /tmp/MERGED-30551269/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider
--- /tmp/LIVE-491564489/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider	2023-10-17 13:01:27.436229259 +0000
+++ /tmp/MERGED-30551269/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider	2023-10-17 13:01:27.440229346 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "14"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 14
+  generation: 15
   labels:
     app: handle-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: d75c8371d5dac2348583b29b4aaa261a4682fcea
+    app.kubernetes.io/version: 9667d34120e2abc4cc2610b1e7371b4a0a068afe
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-provider
@@ -81,7 +81,7 @@
           value: handle
         - name: USE_KORA_LABS
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:7scn4gpa4b2v8zgy6icgz01a1y4yjd29
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:3ha727jqjhp77mbnjyvxpsmfsi4zvv2q
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-491564489/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker /tmp/MERGED-30551269/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker
--- /tmp/LIVE-491564489/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker	2023-10-17 13:01:27.644233741 +0000
+++ /tmp/MERGED-30551269/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker	2023-10-17 13:01:27.644233741 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "47"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 47
+  generation: 48
   labels:
     app: pg-boss-worker
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: d75c8371d5dac2348583b29b4aaa261a4682fcea
+    app.kubernetes.io/version: 9667d34120e2abc4cc2610b1e7371b4a0a068afe
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-pg-boss-worker
@@ -93,7 +93,7 @@
           value: pool-metadata,pool-metrics
         - name: STAKE_POOL_PROVIDER_URL
           value: http://dev-preview-cardanojs-backend.dev-preview.svc.cluster.local
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:7scn4gpa4b2v8zgy6icgz01a1y4yjd29
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:3ha727jqjhp77mbnjyvxpsmfsi4zvv2q
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-491564489/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector /tmp/MERGED-30551269/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector
--- /tmp/LIVE-491564489/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector	2023-10-17 13:01:27.844238051 +0000
+++ /tmp/MERGED-30551269/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector	2023-10-17 13:01:27.844238051 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "47"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 47
+  generation: 48
   labels:
     app: stake-pool-projector
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: d75c8371d5dac2348583b29b4aaa261a4682fcea
+    app.kubernetes.io/version: 9667d34120e2abc4cc2610b1e7371b4a0a068afe
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-projector
@@ -71,7 +71,7 @@
               name: stakepool-owner-user.dev-preview-dbsync-db.credentials.postgresql.acid.zalan.do
         - name: PROJECTION_NAMES
           value: stake-pool,stake-pool-metadata-job,stake-pool-metrics-job
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:7scn4gpa4b2v8zgy6icgz01a1y4yjd29
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:3ha727jqjhp77mbnjyvxpsmfsi4zvv2q
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-491564489/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider /tmp/MERGED-30551269/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider
--- /tmp/LIVE-491564489/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider	2023-10-17 13:01:28.076243050 +0000
+++ /tmp/MERGED-30551269/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider	2023-10-17 13:01:28.076243050 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "44"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 44
+  generation: 45
   labels:
     app: stake-pool-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: d75c8371d5dac2348583b29b4aaa261a4682fcea
+    app.kubernetes.io/version: 9667d34120e2abc4cc2610b1e7371b4a0a068afe
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-provider
@@ -83,7 +83,7 @@
           value: http://dev-preview-cardano-stack-metadata.dev-preview.svc.cluster.local
         - name: USE_TYPEORM_STAKE_POOL_PROVIDER
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:7scn4gpa4b2v8zgy6icgz01a1y4yjd29
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:3ha727jqjhp77mbnjyvxpsmfsi4zvv2q
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-491564489/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor /tmp/MERGED-30551269/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor
--- /tmp/LIVE-491564489/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor	2023-10-17 13:01:28.304247963 +0000
+++ /tmp/MERGED-30551269/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor	2023-10-17 13:01:28.304247963 +0000
@@ -5,7 +5,7 @@
   generation: 2
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: d75c8371d5dac2348583b29b4aaa261a4682fcea
+    app.kubernetes.io/version: 9667d34120e2abc4cc2610b1e7371b4a0a068afe
     instance: primary
   name: lace-backend-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-491564489/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor /tmp/MERGED-30551269/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor
--- /tmp/LIVE-491564489/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor	2023-10-17 13:01:28.500252186 +0000
+++ /tmp/MERGED-30551269/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor	2023-10-17 13:01:28.500252186 +0000
@@ -5,7 +5,7 @@
   generation: 2
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: d75c8371d5dac2348583b29b4aaa261a4682fcea
+    app.kubernetes.io/version: 9667d34120e2abc4cc2610b1e7371b4a0a068afe
     instance: primary
   name: lace-handle-provider-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-491564489/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor /tmp/MERGED-30551269/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor
--- /tmp/LIVE-491564489/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor	2023-10-17 13:01:28.704256582 +0000
+++ /tmp/MERGED-30551269/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor	2023-10-17 13:01:28.704256582 +0000
@@ -5,7 +5,7 @@
   generation: 2
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: d75c8371d5dac2348583b29b4aaa261a4682fcea
+    app.kubernetes.io/version: 9667d34120e2abc4cc2610b1e7371b4a0a068afe
     instance: primary
   name: lace-stake-pool-provider-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-491564489/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-30551269/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-491564489/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend	2023-10-17 13:01:28.920261237 +0000
+++ /tmp/MERGED-30551269/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend	2023-10-17 13:01:28.920261237 +0000
@@ -19,7 +19,7 @@
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: d75c8371d5dac2348583b29b4aaa261a4682fcea
+    app.kubernetes.io/version: 9667d34120e2abc4cc2610b1e7371b4a0a068afe
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
diff -u -N /tmp/LIVE-491564489/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-30551269/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-491564489/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-10-17 13:01:29.124265632 +0000
+++ /tmp/MERGED-30551269/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-10-17 13:01:29.128265719 +0000
@@ -16,7 +16,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: d75c8371d5dac2348583b29b4aaa261a4682fcea
+    app.kubernetes.io/version: 9667d34120e2abc4cc2610b1e7371b4a0a068afe
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-491564489/v1.Service.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-30551269/v1.Service.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-491564489/v1.Service.dev-preview.dev-preview-cardanojs-backend	2023-10-17 13:01:26.016198661 +0000
+++ /tmp/MERGED-30551269/v1.Service.dev-preview.dev-preview-cardanojs-backend	2023-10-17 13:01:26.016198661 +0000
@@ -5,7 +5,7 @@
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: d75c8371d5dac2348583b29b4aaa261a4682fcea
+    app.kubernetes.io/version: 9667d34120e2abc4cc2610b1e7371b4a0a068afe
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
diff -u -N /tmp/LIVE-491564489/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-30551269/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-491564489/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-10-17 13:01:26.208202799 +0000
+++ /tmp/MERGED-30551269/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-10-17 13:01:26.212202885 +0000
@@ -5,7 +5,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: d75c8371d5dac2348583b29b4aaa261a4682fcea
+    app.kubernetes.io/version: 9667d34120e2abc4cc2610b1e7371b4a0a068afe
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-491564489/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider /tmp/MERGED-30551269/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider
--- /tmp/LIVE-491564489/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider	2023-10-17 13:01:26.408207108 +0000
+++ /tmp/MERGED-30551269/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider	2023-10-17 13:01:26.408207108 +0000
@@ -5,7 +5,7 @@
   labels:
     app: handle-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: d75c8371d5dac2348583b29b4aaa261a4682fcea
+    app.kubernetes.io/version: 9667d34120e2abc4cc2610b1e7371b4a0a068afe
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-provider
diff -u -N /tmp/LIVE-491564489/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider /tmp/MERGED-30551269/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider
--- /tmp/LIVE-491564489/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider	2023-10-17 13:01:26.608211418 +0000
+++ /tmp/MERGED-30551269/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider	2023-10-17 13:01:26.608211418 +0000
@@ -5,7 +5,7 @@
   labels:
     app: stake-pool-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: d75c8371d5dac2348583b29b4aaa261a4682fcea
+    app.kubernetes.io/version: 9667d34120e2abc4cc2610b1e7371b4a0a068afe
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-provider

mchappell
mchappell approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@mchappell mchappell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@DominikGuzei DominikGuzei requested review from mkazlauskas and removed request for tommayeliog October 18, 2023 10:44
@DominikGuzei DominikGuzei force-pushed the chore/lw-6514-fix-trezor-connect-imports branch from f7c09b7 to 138ac3e Compare October 18, 2023 11:06
@DominikGuzei DominikGuzei changed the title chore(hardware-trezor): fix trezor connect web import LW-6514 fix(hardware-trezor): fix trezor connect web import LW-6514 Oct 18, 2023
@DominikGuzei DominikGuzei changed the title fix(hardware-trezor): fix trezor connect web import LW-6514 fix(hardware-trezor): Trezor connect web import LW-6514 Oct 18, 2023
@DominikGuzei
Copy link
Member Author

DominikGuzei commented Oct 18, 2023

@marcin-mazurek @mkazlauskas @mchappell I just realized that this PR (and a new release) is not necessary - the code is fine as it was before and only the import changes in Lace have been relevant to fix the issues we had.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkazlauskas mkazlauskas mkazlauskas approved these changes

@mchappell mchappell mchappell approved these changes

+1 more reviewer

@marcin-mazurek marcin-mazurek marcin-mazurek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@DominikGuzei DominikGuzei

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@DominikGuzei @mkazlauskas @marcin-mazurek @mchappell