Document throwable vs structural PredicateFailures
#772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhuesch
force-pushed
the
mhuesch/document_STS_PFs_structural_throwable
branch
from
104e37c to
318d741
Compare
dnadales
approved these changes
Aug 20, 2019
byron/chain/executable-spec/src/Cardano/Spec/Chain/STS/Rule/SigCnt.hs
Outdated
Show resolved
Hide resolved
dnadales
reviewed
Aug 20, 2019
dnadales
reviewed
Aug 20, 2019
mhuesch
commented
Aug 20, 2019
mhuesch
added a commit
that referenced
this pull request
Aug 20, 2019
Add comments on `PredicateFailure` data declarations. Rename a few constructors, adding a `S_` prefix to indicate their structural-ness. Document the convention in the class definition.
mhuesch
force-pushed
the
mhuesch/document_STS_PFs_structural_throwable
branch
from
fac7363 to
ef891b2
Compare
|
I'm going to merge this so I can get on with revising my other PRs which build on top of this. If we need to amend the comments later let's use a separate PR. |
kevinhammond
pushed a commit
that referenced
this pull request
Oct 28, 2019
kevinhammond
pushed a commit
that referenced
this pull request
Oct 28, 2019
…_structural_throwable Document throwable vs structural `PredicateFailure`s
nc6
pushed a commit
that referenced
this pull request
May 19, 2020
…ameters Expose adoptedProtocolParameters from validation state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add comments on
PredicateFailuredata declarations.Rename a few constructors, adding a
S_prefix to indicate theirstructural-ness.
Document the convention in the class definition.