Skip to content

chore(cli): removes default value for deployment env #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2025
Merged

chore(cli): removes default value for deployment env #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab785fd
chore(cli): removes default value for deployment env
jmgilman Jul 8, 2025
cbfe776
chore: fixes test
jmgilman Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion foundry/operator/internal/controller/suite_env_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ func newRawBundle() string {
return `{
_#def
_#def: {
env: string | *"dev"
env: string
modules: {
[string]: {
instance?: string
Expand Down
1 change: 0 additions & 1 deletion lib/project/deployment/deployer/deployer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ const (
// This is the hardcoded default environment for the deployment.
// We always deploy to the dev environment by default and do not allow
// the user to change this.
// This is also the default for the `env` field in the deployment module.
DEFAULT_ENV = "dev"

// This is the name of the environment file which is merged with the deployment module.
Expand Down
2 changes: 1 addition & 1 deletion lib/schema/blueprint/project/deployment.cue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ package project

#ModuleBundle: {
// Env contains the environment to deploy the modules to.
env: string | *"dev"
env: string

// Modules contains the deployment modules.
modules: [string]: #Module
Expand Down