Skip to content

Conversation

@stanislav-tkach
Copy link
Member

@stanislav-tkach stanislav-tkach commented Jan 23, 2025

Description

  • Move the Cip0134Uri type to the cadrano-blockchain-types crate (from rbac-registration)
  • Add the txs function to MultiEraBlock.
  • Implement From<TxnIndex> for usize.

Description of Changes

This is a part of changes from the #127 pull request that is unrelated to the rbac-registration crate.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 281/281}$ | ${\color{red}Fail: 0/281}$ |

@stanislav-tkach stanislav-tkach merged commit eaf071e into main Jan 23, 2025
22 checks passed
@stanislav-tkach stanislav-tkach deleted the move-cip134uri-type-to-cardano-blockchain-types-crate branch January 23, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants