Skip to content

Conversation

@bkioshn
Copy link
Contributor

@bkioshn bkioshn commented Feb 12, 2025

Description

  • Properly set payment address
  • Fix raw nonce
  • Add block data that is used for testing

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

Signed-off-by: bkioshn <bkioshn@gmail.com>
Signed-off-by: bkioshn <bkioshn@gmail.com>
@bkioshn bkioshn changed the title fix(cardano-blockchain-types): CIP36 payment addr, nonce and add test from block data fix(rust/cardano-blockchain-types): CIP36 payment addr, nonce and add test from block data Feb 12, 2025
@bkioshn bkioshn self-assigned this Feb 12, 2025
@github-actions
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 278/278}$ | ${\color{red}Fail: 0/278}$ |

@bkioshn bkioshn merged commit c2077f2 into main Feb 12, 2025
20 of 27 checks passed
@bkioshn bkioshn deleted the fix/cip36-and-test branch February 12, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants