Skip to content

Conversation

@stanislav-tkach
Copy link
Member

@stanislav-tkach stanislav-tkach commented Feb 19, 2025

Description

  • Rename TransactionHash to TransactionId.
  • Add the StakeAddress type.
  • Implement conversion between cardano-blockchain-types::Network and pallas::Network.
  • Bump versions.

Related Pull Requests

input-output-hk/catalyst-voices#1367

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@stanislav-tkach stanislav-tkach added the do not merge yet PR is not ready to be merged yet label Feb 19, 2025
@stanislav-tkach stanislav-tkach self-assigned this Feb 19, 2025
@github-actions
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 287/287}$ | ${\color{red}Fail: 0/287}$ |

@github-actions
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 289/289}$ | ${\color{red}Fail: 0/289}$ |

@github-actions
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 289/289}$ | ${\color{red}Fail: 0/289}$ |

@stanislav-tkach stanislav-tkach marked this pull request as ready for review February 20, 2025 11:30
@stanislav-tkach stanislav-tkach added review me PR is ready for review and removed do not merge yet PR is not ready to be merged yet labels Feb 20, 2025
@stanislav-tkach
Copy link
Member Author

All tests are passed before using the unpublished tag.

Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stanislav-tkach stanislav-tkach merged commit ca010d7 into main Feb 20, 2025
18 of 21 checks passed
@stanislav-tkach stanislav-tkach deleted the rename-transaction-hash-and-add-stake-address-type branch February 20, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants