Skip to content

fix(rust/catalyst-types): IdUri::is_id take self by reference #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2025
Merged

fix(rust/catalyst-types): IdUri::is_id take self by reference #221

merged 1 commit into from
Feb 26, 2025

Conversation

@stanislav-tkach
Copy link
Member

@stanislav-tkach stanislav-tkach commented Feb 25, 2025 •
edited
Loading

Description

  • Update IdUri::is_id method signature (&self instead of self).

@stanislav-tkach stanislav-tkach added the review me PR is ready for review label Feb 25, 2025
Mr-Leshiy
Mr-Leshiy approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stanislav-tkach stanislav-tkach merged commit 0a460cf into main Feb 26, 2025
4 checks passed
@stanislav-tkach stanislav-tkach deleted the id-uri-is-id-reference branch February 26, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mr-Leshiy Mr-Leshiy Mr-Leshiy approved these changes

@stevenj stevenj Awaiting requested review from stevenj

Assignees

No one assigned

Labels

review me PR is ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stanislav-tkach @Mr-Leshiy