Skip to content

Conversation

@bkioshn
Copy link
Contributor

@bkioshn bkioshn commented Sep 20, 2024

Description

  • Fix linter problem
  • Generalize decoder CBOR helper

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@bkioshn bkioshn self-assigned this Sep 20, 2024
@bkioshn bkioshn marked this pull request as draft September 20, 2024 06:34
@bkioshn bkioshn marked this pull request as ready for review September 20, 2024 09:13
@stevenj stevenj added the review me PR is ready for review label Sep 20, 2024
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj merged commit 750153c into main Sep 21, 2024
@stevenj stevenj deleted the fix/linter-cbor-helper branch September 21, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants