Skip to content

feat(rust/catalyst-voting): Jormungandr transaction serde #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Oct 14, 2024
Merged

feat(rust/catalyst-voting): Jormungandr transaction serde #58

merged 21 commits into from
Oct 14, 2024

Conversation

@Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Oct 10, 2024

Description

Added a new v1::Tx struct which is a representation of the jornungandr VoteCast transaction.
Added serde implementation for the v1::Tx and underlying objects.

Related Issue(s)

#55

@Mr-Leshiy Mr-Leshiy self-assigned this Oct 10, 2024
@Mr-Leshiy Mr-Leshiy added the review me PR is ready for review label Oct 10, 2024
@Mr-Leshiy Mr-Leshiy requested review from cong-or and stevenj October 10, 2024 16:54
@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024 •
edited
Loading

✅ Test Report | ${\color{lightgreen}Pass: 209/209}$ | ${\color{red}Fail: 0/209}$ |

bkioshn
bkioshn reviewed Oct 11, 2024
View reviewed changes
@Mr-Leshiy Mr-Leshiy requested a review from bkioshn October 11, 2024 09:48
@minikin minikin enabled auto-merge (squash) October 11, 2024 11:16
bkioshn
bkioshn reviewed Oct 11, 2024
View reviewed changes
@Mr-Leshiy Mr-Leshiy mentioned this pull request Oct 11, 2024
Merged
cong-or
cong-or reviewed Oct 11, 2024
View reviewed changes
@Mr-Leshiy Mr-Leshiy requested review from bkioshn and cong-or October 14, 2024 07:12
bkioshn
bkioshn reviewed Oct 14, 2024
View reviewed changes
Copy link
Contributor

@bkioshn bkioshn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cong-or
cong-or approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@cong-or cong-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minikin minikin merged commit 0a5fd6e into main Oct 14, 2024
22 checks passed
@minikin minikin deleted the feat/jorm-tx branch October 14, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkioshn bkioshn bkioshn left review comments

@cong-or cong-or cong-or approved these changes

@stevenj stevenj Awaiting requested review from stevenj

Assignees

@Mr-Leshiy Mr-Leshiy

Labels

review me PR is ready for review

Projects

Catalyst
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Mr-Leshiy @bkioshn @cong-or @minikin @saibatizoku