Skip to content

Conversation

@Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Oct 16, 2024

Description

Fixed build issues for catalyst-voting.
Added missing feature flaggetrandom for rand_core dependency. Updated the way of conversion from CtOption to Option type to be compatible with the subtle version 2.4.1.
Added missing decoding implementation for some objects.

@Mr-Leshiy Mr-Leshiy self-assigned this Oct 16, 2024
@Mr-Leshiy Mr-Leshiy added the review me PR is ready for review label Oct 16, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2024

Test Report | ${\color{lightgreen}Pass: 211/211}$ | ${\color{red}Fail: 0/211}$ |

minikin
minikin previously approved these changes Oct 16, 2024
Copy link
Collaborator

@minikin minikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Mr-Leshiy Mr-Leshiy requested a review from minikin October 16, 2024 16:50
@Mr-Leshiy Mr-Leshiy marked this pull request as draft October 17, 2024 06:46
@Mr-Leshiy Mr-Leshiy marked this pull request as ready for review October 17, 2024 11:12
Copy link
Collaborator

@minikin minikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Mr-Leshiy Mr-Leshiy merged commit d0b5784 into main Oct 17, 2024
23 checks passed
@Mr-Leshiy Mr-Leshiy deleted the fix/catalyst-voting-build branch October 17, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants