Skip to content

Conversation

@Mr-Leshiy
Copy link
Contributor

Description

Making Cip0134UriSet to not expose it for the public usage, as its an internal implementation detail of the rbac-registration library.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@Mr-Leshiy Mr-Leshiy self-assigned this Nov 20, 2025
@Mr-Leshiy Mr-Leshiy added review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team labels Nov 20, 2025
@github-actions
Copy link
Contributor

📚 Docs Preview

The docs for this PR can be previewed at the following URL:

https://docs.dev.projectcatalyst.io/libs/feat/make-cip134uriset-private

@github-actions
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 566/566}$ | ${\color{red}Fail: 0/566}$ |

@Mr-Leshiy Mr-Leshiy merged commit b9d316e into feat/rbac Nov 20, 2025
32 of 34 checks passed
@Mr-Leshiy Mr-Leshiy deleted the feat/make-cip134uriset-private branch November 20, 2025 05:15
@github-project-automation github-project-automation bot moved this from New to ✅ Done in Catalyst Nov 20, 2025
Copy link
Member

@stanislav-tkach stanislav-tkach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too late, but I don't like it. 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants