Skip to content

Conversation

@Mr-Leshiy
Copy link
Contributor

Description

Added a final pieces for the GeneralisedTx CBOR decoding functionality.

Related Issue(s)

Closes #75

Description of Changes

  • Added missing signature: coset::CoseSign field with decoding implementation.
  • Added missing event: EventMap field and underlying structs with decoding implementation.

@Mr-Leshiy Mr-Leshiy self-assigned this Nov 15, 2024
@Mr-Leshiy Mr-Leshiy added the review me PR is ready for review label Nov 15, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024

Test Report | ${\color{lightgreen}Pass: 217/217}$ | ${\color{red}Fail: 0/217}$ |

Copy link
Contributor

@cong-or cong-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Mr-Leshiy Mr-Leshiy merged commit d4dc27a into main Nov 15, 2024
24 checks passed
@Mr-Leshiy Mr-Leshiy deleted the feat/vote-tx-v2 branch November 15, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Generalizes voting tx decoding implementation

3 participants