Update rewards #141
Merged
Update rewards #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saibatizoku
approved these changes
May 25, 2022
Mr-Leshiy
approved these changes
May 26, 2022
Use VoterHIR as the output format for the snapshot tool
Limit overall influence of actors in an election by capping their maximum voting power at arbitrary levels. Since a lot of configurations are going in the snapshot process, I'm thinking of having it output two different artifacts: the list of VoterHIRs, as already proposed, and another one which is a light wrapper around VoterHIR which contains contributions from snapshot, to be used for the reward process. I'm proposing to keep the separate because the first one is more general, while the second one is tied to our current deployment and more likely to change.
cameron1024
approved these changes
Jun 27, 2022
| Ok(rewards_to_mainnet_addresses(rewards, snapshot)) | ||
| let mut total_active_stake = 0u64; | ||
| let mut stake_per_voter = HashMap::new(); | ||
| // iterative as Iterator::sum() panic on overflows |
Contributor
There was a problem hiding this comment.
Could something like this work?
let total_active_stake = active_addresses
.iter()
.try_fold(0u64, |acc, x| acc.checked_add(x.hir.voting_power.into()));Not a big deal, not like there's anything wrong with for loops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.