Skip to content

Better deserialization errors #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Aug 24, 2022
Merged

Better deserialization errors #153

merged 12 commits into from
Aug 24, 2022

Conversation

@cameron1024
Copy link
Contributor

@cameron1024 cameron1024 commented Jul 21, 2022 •
edited
Loading

Replaces a few custom deserializers with manual Deserialize implementations (with descriptions of the format of the data for better error messages)

An example error:

Error:
   0: error decoding response body: didn't match `$N in ada` pattern at line 1 column 146
   1: didn't match `$N in ada` pattern at line 1 column 146

Location:
   catalyst-toolbox/src/bin/cli/ideascale/mod.rs:119

zeegomo
zeegomo suggested changes Jul 28, 2022
View reviewed changes
zeegomo
zeegomo reviewed Jul 28, 2022
View reviewed changes
@minikin minikin requested review from Mr-Leshiy and zeegomo August 9, 2022 12:05
@Mr-Leshiy
Copy link
Contributor

Mr-Leshiy commented Aug 10, 2022

need to update with the latest master :)

@cameron1024 cameron1024 requested a review from a team August 18, 2022 15:39
saibatizoku
saibatizoku approved these changes Aug 19, 2022
View reviewed changes
Copy link

@saibatizoku saibatizoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tracing! awesome

@cameron1024 cameron1024 merged commit 1186ad2 into main Aug 24, 2022
@cameron1024 cameron1024 deleted the better-errors branch August 24, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saibatizoku saibatizoku saibatizoku approved these changes

@Mr-Leshiy Mr-Leshiy Mr-Leshiy approved these changes

@zeegomo zeegomo Awaiting requested review from zeegomo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cameron1024 @Mr-Leshiy @saibatizoku @zeegomo