Redemption features to old API #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsubhuman
commented
Jan 18, 2019
wallet-wasm/src/lib.rs
Outdated
| #[derive(Serialize, Deserialize, Debug)] | ||
| struct WalletRedeemInput { | ||
| protocol_magic: cardano::config::ProtocolMagic, | ||
| redemption_key: redeem::PrivateKey, |
Contributor
Author
There was a problem hiding this comment.
Am I getting it right that caller might pass protocol_magic as integer number, and redemption_key as string or byte-array, and they will be deserialised into right types after calling input_json!?
vsubhuman
commented
Jan 18, 2019
wallet-wasm/src/lib.rs
Outdated
| .map_err(|e| JsValue::from_str(&format! {"{:?}", e})) | ||
| ); | ||
| let witness = tx::TxInWitness::redeem( | ||
| data.protocol_magic, &data.redemption_key, &tx.0.id()); |
Contributor
Author
There was a problem hiding this comment.
Here I've imagined how new functionality for redemption signing might look:
But of course will update to actual new functionality when @NicolasDP adds signRedeem to new API
Contributor
Author
|
Need to add tests yet, so still a WIP |
rooooooooob
reviewed
Jan 21, 2019
vsubhuman
changed the title
Contributor
Author
|
@NicolasDP, ready for final review and merge |
NicolasDP
approved these changes
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added couple of functions to
wasm-wallet/lib.rsimplementing required functionality: