Skip to content

Decentralization of configuration parameters phase 1 - Aggregator local parameters #2736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Decentralization of configuration parameters phase 1 - Aggregator local parameters #2736

wants to merge 2 commits into from

Conversation

turmelclem
Copy link
Collaborator

Content

This PR includes...

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)
    • Add ADR blog post or Dev ADR entry (if relevant)
    • No new TODOs introduced

Comments

Issue(s)

Relates to #YYY or Closes #YYY

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 13, 2025
View reviewed changes
mithril-aggregator/src/dependency_injection/containers/serve.rs
pub(crate) epoch_service: EpochServiceWrapper,

/// Mithril network configuration provider
pub(crate) mithril_network_configuration_provider: Arc<dyn MithrilNetworkConfigurationProvider>,

Check warning

Code scanning / clippy

field mithril_network_configuration_provider is never read Warning

field mithril\_network\_configuration\_provider is never read
mithril-aggregator/src/dependency_injection/containers/serve.rs
pub(crate) epoch_service: EpochServiceWrapper,

/// Mithril network configuration provider
pub(crate) mithril_network_configuration_provider: Arc<dyn MithrilNetworkConfigurationProvider>,

Check warning

Code scanning / clippy

field mithril_network_configuration_provider is never read Warning

field mithril\_network\_configuration\_provider is never read
@github-actions GitHub Actions
Copy link

Test Results

    4 files  ±0    168 suites  ±0   24m 11s ⏱️ -17s
2 227 tests ±0  2 227 ✅ ±0  0 💤 ±0  0 ❌ ±0 
6 879 runs  ±0  6 879 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 407ea74. ± Comparison against base commit 69e39ed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@turmelclem