Skip to content

Conversation

@Alenar
Copy link
Collaborator

@Alenar Alenar commented Nov 14, 2025

Content

This PR rework the test-client workflow and add a new test case: verification of the node startup after conversion of the ledger to lmbd backend.

test-client refactor details

  • add a prepare job, on which all other jobs depends, to share the prepare steps that was done previously on all jobs.
  • use the global env and the job env keys to populate the environment variables instead of using GITHUB_ENV
  • simplify the jobs names so the matrix combinatory is more visable in run: test-binaries -> bin, test-docker -> docker, test-mithril-client-wasm -> wasm
  • extract the cardano database download checks from the bin and docker jobs into a bin-cdb-download and docker-cdb-download jobs: this remove the extra_args dimension from the bin and docker matrixes, and allow better controls and coverage of the cardano database downloads cases

new test case: verification of the node startup after conversion of the ledger to lmbd

  • update .github/workflows/scripts/verify-cardano-db-restoration.sh:
    • add a parameter analysis steps to allow easy addition of future parameters to the script
    • --include-ancillary must now be passed without double quote
    • add --ledger-backend parameter, when the next passed value is lmdb it update the docker run command to configure the correct ledger backend
  • add ledger_backend matrix dimension to the bin-cdb-download job with one item: in-memory, the lmdb variant is passed through a matrix.include to avoid multiplication of the matrix since we run it in only one specific configuration (with ubuntu 24.04 x86, ancillary included, and v2 backend)

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • No new TODOs introduced

Issue(s)

Closes #2679

@Alenar Alenar requested a review from jpraynaud November 14, 2025 15:56
@Alenar Alenar self-assigned this Nov 14, 2025
@Alenar Alenar changed the title Djo/2679/ci/test client check fast bootstrap after lmdb conversion ci(test-client): check fast bootstrap after lmdb conversion Nov 14, 2025
@github-actions
Copy link

github-actions bot commented Nov 14, 2025

Test Results

    4 files  ±0    168 suites  ±0   22m 36s ⏱️ - 1m 5s
2 210 tests ±0  2 210 ✅ ±0  0 💤 ±0  0 ❌ ±0 
6 895 runs  ±0  6 895 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 87e278d. ± Comparison against base commit b9f2466.

♻️ This comment has been updated with latest results.

@Alenar Alenar temporarily deployed to testing-preview November 14, 2025 16:09 — with GitHub Actions Inactive
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alenar Alenar force-pushed the djo/2679/ci/test-client-check-fast-bootstrap-after-lmdb-conversion branch from 0c02959 to 87e278d Compare November 17, 2025 11:28
@Alenar Alenar temporarily deployed to testing-preview November 17, 2025 11:39 — with GitHub Actions Inactive
@Alenar Alenar merged commit 716b468 into main Nov 17, 2025
41 checks passed
@Alenar Alenar deleted the djo/2679/ci/test-client-check-fast-bootstrap-after-lmdb-conversion branch November 17, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add fast bootstrap of Cardano node with LMDB UTxO-HD verification in CI

3 participants