feat: simple aggregator discovery #2779

jpraynaud · 2025-11-14T16:10:29Z

Content

This PR includes...

Pre-submit checklist

Branch
- Tests are provided (if possible)
- Crates versions are updated (if relevant)
- CHANGELOG file is updated (if relevant)
- Commit sequence broadly makes sense
- Key commits have useful messages
PR
- All check jobs of the CI have succeeded
- Self-reviewed the diff
- Useful pull request description
- Reviewer requested
Documentation
- Update README file (if relevant)
- Update documentation website (if relevant)
- Add dev blog post (if relevant)
- Add ADR blog post or Dev ADR entry (if relevant)
- No new TODOs introduced

Issue(s)

Closes #2726

internal/mithril-aggregator-discovery/src/capabilities_discoverer.rs

mithril-client/src/client.rs

Copilot

Pull Request Overview

This PR implements a simple aggregator discovery mechanism to enable the Mithril client to automatically discover and connect to available aggregators in a network.

Key changes:

Introduces a new mithril-aggregator-discovery crate with discoverer implementations
Refactors the ClientBuilder API to support aggregator discovery modes (automatic vs. explicit URL)
Adds capability-based filtering and randomization of aggregator selection

Reviewed Changes

Copilot reviewed 18 out of 20 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
`internal/mithril-aggregator-discovery/Cargo.toml`	Defines the new aggregator discovery crate with dependencies
`internal/mithril-aggregator-discovery/src/lib.rs`	Exports the public API for aggregator discovery
`internal/mithril-aggregator-discovery/src/interface.rs`	Defines the `AggregatorDiscoverer` trait
`internal/mithril-aggregator-discovery/src/model.rs`	Implements `MithrilNetwork` and `AggregatorEndpoint` models
`internal/mithril-aggregator-discovery/src/http_config_discoverer.rs`	HTTP-based discoverer that fetches aggregator lists from remote configuration
`internal/mithril-aggregator-discovery/src/capabilities_discoverer.rs`	Filters aggregators by required capabilities
`internal/mithril-aggregator-discovery/src/rand_discoverer.rs`	Shuffles aggregator order using randomization
`internal/mithril-aggregator-discovery/src/test/`	Test utilities and doubles for testing
`mithril-client/src/client.rs`	Refactors client builder to support aggregator discovery
`mithril-client/Cargo.toml`	Adds dependency on the new discovery crate
`Makefile`, `Cargo.toml`, `.github/workflows/ci.yml`	Build configuration updates
`README.md`	Documentation for the new crate

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-14T16:13:23Z

internal/mithril-aggregator-discovery/src/test/double/discoverer.rs

+impl AggregatorDiscovererFake {
+    /// Creates a new `AggregatorDiscovererFake` instance with the provided results.
+    pub fn new(results: Vec<AggregatorListReturn>) -> Self {
+        dbg!(&results);


Debug statement should be removed. This dbg! macro call will print to stderr in production code and is typically used only during development.

Suggested change

dbg!(&results);

Copilot · 2025-11-14T16:13:23Z

internal/mithril-aggregator-discovery/src/interface.rs

+pub trait AggregatorDiscoverer: Sync + Send {
+    /// Get an iterator over a list of available aggregators in a Mithril network.
+    ///
+    /// Note: there is no guarantee that the returned aggregators is sorted, complete or up-to-date.


Corrected grammar: 'aggregators is' should be 'aggregators are'.

Suggested change

/// Note: there is no guarantee that the returned aggregators is sorted, complete or up-to-date.

/// Note: there is no guarantee that the returned aggregators are sorted, complete or up-to-date.

Copilot · 2025-11-14T16:13:24Z

internal/mithril-aggregator-discovery/Cargo.toml

@@ -0,0 +1,44 @@
+[package]
+name = "mithril-aggregator-discovery"
+description = "Mechanisms to discover aggregator available in a Mithril network."


Corrected grammar: 'aggregator available' should be 'aggregators available'.

Suggested change

description = "Mechanisms to discover aggregator available in a Mithril network."

description = "Mechanisms to discover aggregators available in a Mithril network."

Copilot · 2025-11-14T16:13:24Z

mithril-client/src/client.rs

+        let aggregator_endpoint = match self.aggregator_discovery {
+            AggregatorDiscoveryType::Url(ref url) => url.clone(),
+            AggregatorDiscoveryType::Automatic => {
+                todo!("Implement automatic aggregator discovery")


The todo!() macro will panic at runtime if this code path is executed. Since AggregatorDiscoveryType::Automatic is a public API variant, this creates a potential runtime failure. Consider either removing the Automatic variant until implemented, or returning a proper error with context.

Suggested change

todo!("Implement automatic aggregator discovery")

return Err(anyhow!("Automatic aggregator discovery is not yet implemented"));

Copilot · 2025-11-14T16:13:24Z

README.md

+
+  - [**Mithril aggregator client**](./internal/mithril-aggregator-client): a client to request data from a Mithril aggregator, used by **Mithril network** nodes and client library.
+
+  - [**Mithril aggregator discovery**](./internal/mithril-aggregator-discovery): mechanisms to discover available Mithril aggregator, used by **Mithril network** nodes and client library.


Corrected grammar: 'aggregator' should be 'aggregators'.

Suggested change

- [**Mithril aggregator discovery**](./internal/mithril-aggregator-discovery): mechanisms to discover available Mithril aggregator, used by **Mithril network** nodes and client library.

- [**Mithril aggregator discovery**](./internal/mithril-aggregator-discovery): mechanisms to discover available Mithril aggregators, used by **Mithril network** nodes and client library.

github-actions · 2025-11-14T16:18:31Z

Test Results

4 files ± 0 172 suites +4 24m 20s ⏱️ + 1m 7s
2 230 tests +20 2 230 ✅ +20 0 💤 ±0 0 ❌ ±0
6 975 runs +80 6 975 ✅ +80 0 💤 ±0 0 ❌ ±0

Results for commit c9f8423. ± Comparison against base commit 57e1490.

♻️ This comment has been updated with latest results.

mithril-client/src/client.rs

internal/mithril-aggregator-discovery/src/capabilities_discoverer.rs

…rer' trait

Implementation for 'AggregatorDiscoverer' trait.

…rator

…ementation of 'Iterator' trait

…rIterator'

…builder

…ities' type Which allows to combine signed entity types and aggregate signature type in a flexible way.

mithril-client-cli/src/commands/tools/aggregator_discovery.rs

+            ));
+        }
+        if required_capabilities.len() == 1 {
+            return required_capabilities.into_iter().next().unwrap();


mithril-client-cli/src/commands/tools/aggregator_discovery.rs

+            ));
+        }
+        if required_capabilities.len() == 1 {
+            return required_capabilities.into_iter().next().unwrap();


mithril-client-cli/src/commands/tools/aggregator_discovery.rs

+        if required_capabilities.len() == 1 {
+            return required_capabilities.into_iter().next().unwrap();
+        } else {
+            return RequiredAggregatorCapabilities::And(required_capabilities);


mithril-client-cli/src/commands/tools/aggregator_discovery.rs

+        if required_capabilities.len() == 1 {
+            return required_capabilities.into_iter().next().unwrap();
+        } else {
+            return RequiredAggregatorCapabilities::And(required_capabilities);


jpraynaud self-assigned this Nov 14, 2025

github-advanced-security bot found potential problems Nov 14, 2025

View reviewed changes

jpraynaud requested a review from Copilot November 14, 2025 16:11

Copilot started reviewing on behalf of jpraynaud November 14, 2025 16:12 View session

github-advanced-security bot found potential problems Nov 14, 2025

View reviewed changes

Copilot finished reviewing on behalf of jpraynaud November 14, 2025 16:12

Copilot AI reviewed Nov 14, 2025

View reviewed changes

jpraynaud force-pushed the jpraynaud/2726-simple-aggregator-discovery branch from 945d3c2 to c74fb50 Compare November 17, 2025 16:29

github-advanced-security bot found potential problems Nov 17, 2025

View reviewed changes

mithril-client/src/client.rs Fixed Show fixed Hide fixed

mithril-client/src/client.rs Fixed Show fixed Hide fixed

jpraynaud force-pushed the jpraynaud/2726-simple-aggregator-discovery branch from c74fb50 to 434891f Compare November 18, 2025 17:50

github-advanced-security bot found potential problems Nov 18, 2025

View reviewed changes

internal/mithril-aggregator-discovery/src/capabilities_discoverer.rs Fixed Show fixed Hide fixed

internal/mithril-aggregator-discovery/src/capabilities_discoverer.rs Fixed Show fixed Hide fixed

jpraynaud added 18 commits November 19, 2025 16:45

chore(aggregator-discovery): scaffold new crate

97111bc

feat(aggregator-discovery): add models for aggregator endpoint

3be68f4

feat(aggregator-discovery): introduce 'AggregatorDiscoverer' trait

166c031

feat(aggregator-discovery): create test double for 'AggregatorDiscove…

9ab4d58

…rer' trait

feat(aggregator-discovery): add 'HttpConfigAggregatorDiscoverer'

a34afed

Implementation for 'AggregatorDiscoverer' trait.

refactor(aggregator-discovery): 'AggregatorDiscoverer' returns an ite…

76e6ab7

…rator

feat(aggregator-discovery): add 'ShuffleAggregatorDiscoverer' decorator

09dfc38

wip(aggregator-discovery): add 'CapableAggregatorDiscoverer' decorator

353e9e3

fix(aggregator-discovery): 'CapableAggregatorDiscovererIterator' impl…

6a3ecca

…ementation of 'Iterator' trait

test(aggregator-discovery): add tests for 'CapableAggregatorDiscovere…

6ee5693

…rIterator'

refactor(client): prepare client builder for aggregator discovery

30d4d5d

fix(aggregator-discovery): remove unneeded 'crate-type' in 'Cargo.toml'

b7b9eed

refactor(aggregator-discovery): remove the 'rand' feature

4681baa

feat(client): implement basic aggregator discoverer

857d931

feat(aggregator-discovery): implement aggregator discovery in client …

2273b77

…builder

feat(aggregator-discovery): add HTTP timeouts

55a5843

refactor(aggregator-discoverer): introduce 'RequiredAggregatorCapabil…

8b19110

…ities' type Which allows to combine signed entity types and aggregate signature type in a flexible way.

chore(client): re-export missing types from common

426aa37

jpraynaud added 3 commits November 19, 2025 18:10

chore(client): update capabilities to required capabilities

6b35ce4

wip(client-cli)

c55e43b

wip(client-cli): new aggregator discovery command

c9f8423

jpraynaud force-pushed the jpraynaud/2726-simple-aggregator-discovery branch from 434891f to c9f8423 Compare November 19, 2025 17:46

github-advanced-security bot found potential problems Nov 19, 2025

View reviewed changes

	/// Note: there is no guarantee that the returned aggregators is sorted, complete or up-to-date.
	/// Note: there is no guarantee that the returned aggregators are sorted, complete or up-to-date.

	description = "Mechanisms to discover aggregator available in a Mithril network."
	description = "Mechanisms to discover aggregators available in a Mithril network."

	todo!("Implement automatic aggregator discovery")
	return Err(anyhow!("Automatic aggregator discovery is not yet implemented"));


		- [Mithril aggregator client](./internal/mithril-aggregator-client): a client to request data from a Mithril aggregator, used by Mithril network nodes and client library.

		- [Mithril aggregator discovery](./internal/mithril-aggregator-discovery): mechanisms to discover available Mithril aggregator, used by Mithril network nodes and client library.

feat: simple aggregator discovery #2779

Are you sure you want to change the base?

feat: simple aggregator discovery #2779

Conversation

jpraynaud commented Nov 14, 2025

Content

Pre-submit checklist

Issue(s)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check warning

Check warning

Check warning

Check warning

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Nov 14, 2025 •

edited

Loading