chore: remove uneeded crates type from most Cargo.toml
#2783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addition of `staticlib` add a lot of disk usage and build time and is not justified for crates that are not intended to be directly used by third parties (all crates except `mithril-stm` and `mithril-client`).
* mithril-cardano-node-chain from `0.1.9` to `0.1.10` * mithril-cardano-node-internal-database from `0.1.7` to `0.1.8` * mithril-aggregator-client from `0.1.2` to `0.1.3` * mithril-dmq from `0.1.13` to `0.1.14` * mithril-era from `0.1.5` to `0.1.6` * mithril-metric from `0.1.19` to `0.1.20` * mithril-persistence from `0.2.59` to `0.2.60` * mithril-resource-pool from `0.0.8` to `0.0.9` * mithril-ticker from `0.1.3` to `0.1.4` * mithril-signed-entity-lock from `0.0.4` to `0.0.5` * mithril-signed-entity-preloader from `0.0.10` to `0.0.11` * mithril-common from `0.6.27` to `0.6.28`
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR remove the
crate-typefield from all crates exceptmithril-stmandmithril-client(andmithril-client-wasmwhere thecrate-type = ["cdylib"]is mandatory for compilation).Addition of
staticlibadd a lot of disk usage and build time and is not reasonable for crates that are not intended to be directly used by third parties.Pre-submit checklist
Issue(s)
Relates to #2782