Skip to content

[LW-9219] Production build command not working #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 7, 2023
Merged

[LW-9219] Production build command not working #892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba7ac6a
add necessary step for build to readme file
Dec 5, 2023
edef1fc
log build erros
Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

Nami is a browser based wallet extension to interact with the Cardano blockchain. It's an open-source project and built by [**Berry Pool**](https://pipool.online).


### Testnet

[Download testnet version](./build.zip)
Expand Down Expand Up @@ -213,7 +212,12 @@ The `project_id` for API requests can be created under [blockfrost.io](https://b

**Recommended:** Follow this [approach](https://github.com/lxieyang/chrome-extension-boilerplate-react#secrets) in order to keep the keys seperate from the repository.

The quick solution is to go under `./src/config/provider.js` and replace `secrets.PROJECT_ID_MAINNET` and `secrets.PROJECT_ID_TESTNET` with the project ids from blockfrost.
```
# Update secrets file with your own keys
cp secrets.testing.js secrets.development.js
```

The quick solution is to go under `./src/config/provider.js` and replace `secrets.PROJECT_ID_MAINNET`, `secrets.PROJECT_ID_TESTNET`, `secrets.PROJECT_ID_PREVIEW` and `secrets.PROJECT_ID_PREPROD` with the project ids from blockfrost.

##### Requirements

Expand All @@ -222,12 +226,16 @@ The quick solution is to go under `./src/config/provider.js` and replace `secret
##### Start development server

```
# Update secrets file with your own keys
cp secrets.testing.js secrets.development.js
npm start
```

##### Create production build

```
# Update secrets file with your own keys
cp secrets.testing.js secrets.production.js
Copy link
Member

@DominikGuzei DominikGuzei Dec 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, just saw the diff here ;)

npm run build
```

Expand Down
2 changes: 2 additions & 0 deletions secrets.testing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
export default {
PROJECT_ID_MAINNET: 'DUMMY_MAINNET',
PROJECT_ID_TESTNET: 'DUMMY_TESTNET',
PROJECT_ID_PREVIEW: 'DUMMY_PREVIEW',
PROJECT_ID_PREPROD: 'DUMMY_PREPROD',
};
14 changes: 12 additions & 2 deletions utils/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,16 @@ delete config.chromeExtensionBoilerplate;

config.mode = 'production';

webpack(config, function (err) {
if (err) throw err;
webpack(config, function (err, stats) {
if (stats.hasErrors()) {
console.log(
stats.toString({
colors: true,
})
);
}

if (err) {
throw err;
}
});