Skip to content

fix: re-introduce missing environmental variables and add e2e tests #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 21, 2023
Merged

fix: re-introduce missing environmental variables and add e2e tests #227

merged 8 commits into from
Jun 21, 2023

Conversation

jeswr
Copy link
Contributor

@jeswr jeswr commented Jun 19, 2023

No description provided.

@jeswr jeswr force-pushed the chore/test-playwright branch from 62ffdb7 to 5fb17b5 Compare June 20, 2023 01:57
@jeswr jeswr temporarily deployed to ESS PodSpaces June 21, 2023 11:14 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to ESS PodSpaces June 21, 2023 11:14 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to ESS PodSpaces June 21, 2023 11:14 — with GitHub Actions Inactive
@jeswr jeswr marked this pull request as ready for review June 21, 2023 11:14
@jeswr jeswr requested a review from a team as a code owner June 21, 2023 11:15
@jeswr jeswr temporarily deployed to ESS PodSpaces June 21, 2023 11:16 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to ESS PodSpaces June 21, 2023 11:16 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to ESS PodSpaces June 21, 2023 11:16 — with GitHub Actions Inactive
@jeswr jeswr changed the title chore: add e2e tests to make sure the playwright helpers are working properly fix: re-introduce missing environmental variables and add e2e tests Jun 21, 2023
jeswr
jeswr commented Jun 21, 2023
View reviewed changes
packages/internal-test-env/index.ts
Comment on lines +325 to +326
login: process.env.E2E_TEST_USER,
password: process.env.E2E_TEST_PASSWORD
Copy link
Contributor Author

@jeswr jeswr Jun 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only change to this library that gets distributed. The rest is e2e testing.

@jeswr jeswr merged commit 0731039 into main Jun 21, 2023
@jeswr jeswr deleted the chore/test-playwright branch June 21, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@VirginiaBalseiro VirginiaBalseiro VirginiaBalseiro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jeswr @VirginiaBalseiro