Skip to content

breaking changes: remove license year and enforce use of type-only imports #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 21, 2023
Merged

breaking changes: remove license year and enforce use of type-only imports #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd6d8ba
breaking: remove year from license header
jeswr Jun 21, 2023
70f6721
breaking: enforce use of type-imports where possible
jeswr Jun 21, 2023
a6cea68
chore: remove year from license headers
jeswr Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion e2e/browser/test-app/components/appContainer/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//
// Copyright 2022 Inrupt Inc.
// Copyright Inrupt Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal in
Expand Down
2 changes: 1 addition & 1 deletion e2e/browser/test-app/components/solidClient/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//
// Copyright 2022 Inrupt Inc.
// Copyright Inrupt Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal in
Expand Down
2 changes: 1 addition & 1 deletion e2e/browser/test-app/pages/_app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//
// Copyright 2022 Inrupt Inc.
// Copyright Inrupt Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal in
Expand Down
2 changes: 1 addition & 1 deletion e2e/browser/test-app/pages/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//
// Copyright 2022 Inrupt Inc.
// Copyright Inrupt Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal in
Expand Down
2 changes: 1 addition & 1 deletion e2e/browser/test/e2e.playwright.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//
// Copyright 2022 Inrupt Inc.
// Copyright Inrupt Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal in
Expand Down
2 changes: 1 addition & 1 deletion e2e/browser/test/globalSetup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//
// Copyright 2022 Inrupt Inc.
// Copyright Inrupt Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal in
Expand Down
2 changes: 1 addition & 1 deletion eslint-configs/eslint-config-base/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
Copyright 2020 Inrupt Inc.
Copyright Inrupt Inc.

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal in
Expand Down
2 changes: 1 addition & 1 deletion eslint-configs/eslint-config-base/license-header.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//
// Copyright 2023 Inrupt Inc.
// Copyright Inrupt Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal in
Expand Down
18 changes: 17 additions & 1 deletion eslint-configs/eslint-config-lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
Copyright 2020 Inrupt Inc.
Copyright Inrupt Inc.

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal in
Expand Down Expand Up @@ -58,6 +58,22 @@ module.exports = {
// Use typescript's definition checker
"no-use-before-define": ["off"],
"@typescript-eslint/no-use-before-define": ["warn"],

// Ensure that type only imports are used whenever possible; this is also important
// to avoid violating the import/no-unresolved rule when type-only packages such as
// @rdfjs/types are used
//
// For instance if we have:
// ```ts
// import { Term } from '@rdfjs/types';
// ```
// Then the import/no-unresolved rule is violated; but eslint --fix is unable to resolve
// the problem. By adding this rule eslint --fix is able to set this to:
// ```ts
// import type { Term } from '@rdfjs/types';
// ```
//
"@typescript-eslint/consistent-type-imports": ["error", { prefer: "type-imports" }],
},
},
],
Expand Down
2 changes: 1 addition & 1 deletion eslint-configs/eslint-config-react/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
Copyright 2020 Inrupt Inc.
Copyright Inrupt Inc.

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal in
Expand Down
2 changes: 1 addition & 1 deletion packages/internal-playwright-helpers/src/flows/auth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//
// Copyright 2022 Inrupt Inc.
// Copyright Inrupt Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal in
Expand Down
2 changes: 1 addition & 1 deletion packages/internal-playwright-helpers/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//
// Copyright 2022 Inrupt Inc.
// Copyright Inrupt Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal in
Expand Down
2 changes: 1 addition & 1 deletion packages/internal-playwright-helpers/src/pages/cognito.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//
// Copyright 2022 Inrupt Inc.
// Copyright Inrupt Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal in
Expand Down
2 changes: 1 addition & 1 deletion packages/internal-playwright-helpers/src/pages/open-id.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//
// Copyright 2022 Inrupt Inc.
// Copyright Inrupt Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal in
Expand Down
2 changes: 1 addition & 1 deletion packages/internal-playwright-helpers/src/pages/testPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//
// Copyright 2022 Inrupt Inc.
// Copyright Inrupt Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal in
Expand Down
2 changes: 1 addition & 1 deletion packages/internal-test-env/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//
// Copyright 2022 Inrupt Inc.
// Copyright Inrupt Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal in
Expand Down
2 changes: 1 addition & 1 deletion packages/internal-test-env/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//
// Copyright 2022 Inrupt Inc.
// Copyright Inrupt Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal in
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-jsdom-polyfills/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//
// Copyright 2022 Inrupt Inc.
// Copyright Inrupt Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal in
Expand Down
2 changes: 1 addition & 1 deletion playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//
// Copyright 2022 Inrupt Inc.
// Copyright Inrupt Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal in
Expand Down