Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export class CognitoPage {
await this.page.fill(".visible-lg [type=password]", password);
await Promise.all([
// It is important to call waitForNavigation before click to set up waiting.
this.page.waitForNavigation(),
this.page.waitForURL(`.*`),
// Clicking the link will indirectly cause a navigation.
this.page.click(".visible-lg [aria-label=submit]"),
]);
Expand Down
4 changes: 2 additions & 2 deletions packages/internal-playwright-helpers/src/pages/open-id.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
import { Page } from "@playwright/test";

/**
* The Solid-OIDC Broker exposed by ESS wrapped around an underlying OpenID Provider
* The Solid-OIDC Broker exposed by ESS wrapped around an underlying OpenID Provider
*/
export class OpenIdPage {
page: Page;
Expand All @@ -34,7 +34,7 @@ export class OpenIdPage {
async allow() {
await Promise.all([
// It is important to call waitForNavigation before click to set up waiting.
this.page.waitForNavigation(),
this.page.waitForURL(`.*`),
// Clicking the link will indirectly cause a navigation.
this.page.click("text=Allow"),
]);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export class TestPage {
);
await Promise.all([
// It is important to call waitForNavigation before click to set up waiting.
this.page.waitForNavigation(),
this.page.waitForURL(`.*`),
// Clicking the link will indirectly cause a navigation.
this.page.click(TESTID_SELECTORS.LOGIN_BUTTON),
]);
Expand Down