Fix: Cognito page #277
Merged
Fix: Cognito page #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replace deprecated waitForNavigation with waitForURL - use selectors that work across browsers/devices
jeswr
reviewed
Jul 26, 2023
Comment on lines
39
to
42
| // It is important to call waitForURL before click to set up waiting. | ||
| this.page.waitForURL("https://login.inrupt.com/openid"), | ||
| // Clicking the link will indirectly cause a navigation. | ||
| this.page.getByRole('button', { type: 'Submit' }).click(), |
There was a problem hiding this comment.
Is there a reason for added indentations in the diff?
There was a problem hiding this comment.
Oh no, just my formatter I suppose :/
VirginiaBalseiro
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
VirginiaBalseiro
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
VirginiaBalseiro
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
| // Clicking the link will indirectly cause a navigation. | ||
| this.page.click(".visible-lg [aria-label=submit]"), | ||
| // It is important to call waitForURL before click to set up waiting. | ||
| this.page.waitForURL("https://login.inrupt.com/openid"), |
There was a problem hiding this comment.
isnt this too specific since we have have other IDP domains for other envs than podspaces that this is used with?
… for navigation anywhere
VirginiaBalseiro
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
VirginiaBalseiro
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
VirginiaBalseiro
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
|
which repos did we test this with? |
I tested on AMI and solid-client-access-grants and everything works fr me, but feel free to test on your end too. |
jeswr
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should should at least partially address some of the flakiness issues.
replace deprecated waitForNavigation with waitForURL
use selectors that work across browsers/devices