SDK-3193: Fix OpenID prompt locators #310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces two changes: - Moving away from page.waitForNavigation(), which is deprecated - Moving away from using a text-based selector. Instead, a class-based selector is used for legacy code, and a testid-based selector is introduced for future releases, which will include the testid.
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Failure
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Failure
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Failure
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Failure
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Failure
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Failure
jeswr
approved these changes
Aug 15, 2023
There was a race condition where it was possible the test driver would allow the client to their openid provider, be redirected, and the token request be fired before being waited on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces two changes:
selector is used for legacy code, and a testid-based selector is
introduced for future releases, which will include the testid.
The class-based locator is used as a fallback, so that we remain compatible with current releases, and the testid-based one is used when possible against newer releases.