Skip to content

fix: make the allow parameter optional #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 16, 2023
Merged

fix: make the allow parameter optional #483

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9af938c
chore: make the allow parameter optional
jeswr Nov 8, 2023
c51d052
chore: fix lint errors
jeswr Nov 8, 2023
a1072b8
Merge branch 'main' into fix/make-allow-optional
jeswr Nov 13, 2023
f87a4c9
Merge branch 'main' into fix/make-allow-optional
jeswr Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/internal-playwright-helpers/src/flows/auth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export class AuthFlow {
* and completes login after being redirected to client.
*/
async login(
options: { allow: boolean; timeout?: number } = { allow: true },
options: { allow?: boolean; timeout?: number } = {},
): Promise<void> {
const timeoutOptions = { timeout: options.timeout ?? 15_000 };
const testPage = new TestPage(this.page, this.openidProvider);
Expand Down Expand Up @@ -86,7 +86,10 @@ export class AuthFlow {
}

// TODO: handle allow === false
if (options.allow && OpenIdPage.isOnPage(new URL(this.page.url()))) {
if (
options.allow !== false &&
OpenIdPage.isOnPage(new URL(this.page.url()))
) {
completeLoginConditions.push(openIdPage.allow(timeoutOptions));
}
await Promise.all(completeLoginConditions);
Expand Down