Skip to content

Fix build to support references across workspaces #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 9, 2022
Merged

Fix build to support references across workspaces #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ef6937
Fix build setup for workspaces dependencies
NSeydoux Dec 9, 2022
ef573ec
fixup! Fix build setup for workspaces dependencies
NSeydoux Dec 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/internal-playwright-helpers/rollup.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const rollupDefaultConfig = { external, plugins };
export default [
{
...rollupDefaultConfig,
external: ["@inrupt/internal-playwright-helpers"],
external: ["@inrupt/internal-playwright-testids", "@playwright/test"],
input: "src/index.ts",
output: [
{
Expand All @@ -47,7 +47,7 @@ export default [
},
{
...rollupDefaultConfig,
external: ["@inrupt/internal-playwright-helpers"],
external: ["@inrupt/internal-playwright-testids", "@playwright/test"],
input: ["src/index.ts"],
output: {
dir: "dist",
Expand Down
21 changes: 5 additions & 16 deletions packages/internal-playwright-helpers/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,9 @@
{
"extends": "../../tsconfig.base.json",
"compilerOptions": {
/* Basic Options */
"target": "ES2017",
"module": "ESNext",
"moduleResolution": "node",
"lib": ["es2017", "dom"],
"declaration": true,
"outDir": "dist",
"rootDir": "./src",
"strict": true,
"esModuleInterop": true,
// Prevent developers on different OSes from running into problems:
"forceConsistentCasingInFileNames": true,
/* Advanced Options */
"stripInternal": true,
"allowJs": false
"outDir": "./dist",
"rootDir": "./src"
},
"include": ["src/index.ts"]
"include": ["src/index.ts"],
"references": [{ "path": "../internal-playwright-testids" }]
}
6 changes: 2 additions & 4 deletions packages/internal-playwright-testids/rollup.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@ const rollupDefaultConfig = { external, plugins };
export default [
{
...rollupDefaultConfig,
external: [],
input: "index.ts",
input: "src/index.ts",
output: [
{
file: pkg.main,
Expand All @@ -46,8 +45,7 @@ export default [
},
{
...rollupDefaultConfig,
external: [],
input: ["index.ts"],
input: ["src/index.ts"],
output: {
dir: "dist",
entryFileNames: "[name].mjs",
Expand Down
0 ...ages/internal-playwright-testids/index.ts → .../internal-playwright-testids/src/index.ts
View file
Open in desktop
File renamed without changes.
8 changes: 8 additions & 0 deletions packages/internal-playwright-testids/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"extends": "../../tsconfig.base.json",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes so much sense to make this a base.

"compilerOptions": {
"outDir": "./dist",
"rootDir": "./src"
},
"include": ["src/index.ts"],
}
23 changes: 23 additions & 0 deletions tsconfig.base.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{
"compilerOptions": {
/* Basic Options */
"target": "ES2017",
"module": "ESNext",
"moduleResolution": "node",
"lib": ["es2017", "dom"],
"declaration": true,
"strict": true,
"esModuleInterop": true,
// Prevent developers on different OSes from running into problems:
"forceConsistentCasingInFileNames": true,
/* Advanced Options */
"stripInternal": true,
"allowJs": false,
// This is required to have dependencies across workspaces
"composite": true
},
"references": [
{ "path": "./packages/internal-playwright-testids" },
{ "path": "./packages/internal-playwright-helpers" },
]
}