Skip to content

Conversation

@pawelru
Copy link
Contributor

@pawelru pawelru commented Nov 19, 2024

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2024


🎉 Thank you for your contribution! Before this PR can be accepted, we require that you all read and agree to our Contributor License Agreement.
You can digitally sign the CLA by posting a comment on this Pull Request in the format shown below. This agreement will apply to this PR as well as all future contributions on this repository.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
✅ (pawelru)[https://github.com/pawelru]
@Polkas
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@pawelru
Copy link
Contributor Author

pawelru commented Nov 19, 2024

I have read the CLA Document and I hereby sign the CLA

@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2024

badge

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  ---------
R/parse_url.R                   12       0  100.00%
R/tag_examplesShinylive.R       71       0  100.00%
TOTAL                           83       0  100.00%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: d963008

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2024

Unit Tests Summary

 1 files   2 suites   0s ⏱️
15 tests 13 ✅ 2 💤 0 ❌
52 runs  50 ✅ 2 💤 0 ❌

Results for commit d963008.

♻️ This comment has been updated with latest results.

@pawelru
Copy link
Contributor Author

pawelru commented Nov 19, 2024

Submitted

@pawelru pawelru linked an issue Nov 19, 2024 that may be closed by this pull request
32 tasks
Polkas and others added 5 commits November 21, 2024 09:22
# Pull Request

<!-- Please describe your pull request here -->

Signed-off-by: Maciej Nasinski <nasinski.maciej@gmail.com>
@pawelru
Copy link
Contributor Author

pawelru commented Nov 21, 2024

resubmitted

@pawelru pawelru requested a review from donyunardi November 21, 2024 17:59
@pawelru
Copy link
Contributor Author

pawelru commented Nov 21, 2024

@pawelru pawelru added the core label Nov 21, 2024
@pawelru pawelru enabled auto-merge (squash) November 22, 2024 09:47
Copy link

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Suggested some optional changes.. feel free to merge without them:

  • Change for a smoother sentence
  • Adding newlines after each full stop (markdown will keep the phrase in the same line and it's easier to maintain)

Co-authored-by: André Veríssimo <211358+averissimo@users.noreply.github.com>
Signed-off-by: Pawel Rucki <12943682+pawelru@users.noreply.github.com>
@pawelru pawelru merged commit 5a6968b into main Nov 22, 2024
29 of 30 checks passed
@pawelru pawelru deleted the release-candidate-v1.0.0 branch November 22, 2024 10:14
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Release]: 1.0.0

4 participants