Skip to content

Conversation

@hadley
Copy link
Contributor

@hadley hadley commented Oct 7, 2025

expect() now checks its inputs highlighting that you accidentally used it instead of the correct expectation

`expect()` now checks its inputs highlighting that you accidentally used it instead of the correct expectation
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025


🎉 Thank you for your contribution! Before this PR can be accepted, we require that you all read and agree to our Contributor License Agreement.
You can digitally sign the CLA by posting a comment on this Pull Request in the format shown below. This agreement will apply to this PR as well as all future contributions on this repository.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
✅ (Melkiades)[https://github.com/Melkiades]
@hadley
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Signed-off-by: Davide Garolini <dgarolini@gmail.com>
Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks for the changes! These "expect" needed to be clearer for sure ^^

@Melkiades Melkiades enabled auto-merge (squash) October 7, 2025 17:08
@Melkiades Melkiades merged commit 74693f6 into insightsengineering:main Oct 7, 2025
26 of 27 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants