[UAT] scale text on the variable browser plot with the plot hieght and width

[kpagacz]

The text in the right upper corner has a fixed size. As a consequence, it's possible to open the plot with the modal button, increase the plot size and get a very small text (almost ineligible) like this:

Downloading the file produces a gigantic plot with a tiny text:

Would be better if the text somehow scaled with the resolution.

[pawelru]

is this a newly added feature compared to the last release?

[kpagacz]

I don't think so

[gogonzo]

Same applies to the axis text/title etc

[chlebowa]

It's easy enough to do for a single ggplot but nested gTree objects are a different story.

[nikolas-burkoff]

hmm - so it looks like the output from plot_var_summary is either a ggplot object (in which case we want to change the size of the text) or not - in which case it looks like this

in which case we don't really care about the font size.

So we could add the font size inside this code block - it's also probably easiest to have a font size slider in the UI to let users pick it rather than trying anything clever and automatic.

[nikolas-burkoff]

You can also use the ggplot2_args to handle this - for example see here @Polkas is the person to ask about those and see teal.widgets for more details

[lcd2yyz]

I do like the idea of font size slider, it would be a nice value added to all plot rendering through the widget.
Potential follow-up question

• How to determine/set a font size range that make sense?
• Does the font size adjustment need to be handled differently between ggplot vs grid/gTree objects?

[nikolas-burkoff]

I do like the idea of font size slider, it would be a nice value added to all plot rendering through the widget.

So this is a nice idea but I'm not sure it's feasible as plot_with_settings allows lots of different types of graphical output to be displayed all of which handle font sizes differently (if you look at the km plot in tmc or the lineplot in teal.goshawk or the scatterplotmatrix in tmg) and I think different parts of graphs (axes, titles etc.) can be controlled differently too.

In some modules in teal.osprey and teal.goshawk (and pca in tmg) we do have font size sliders but they are module specific and my suspicion is that is how it would have to be - I'd suggest adding a ticket into teal.widgets to explore further and we'd leave this issue for just the variable browser

[chlebowa]

I was trying to capture the plot before downloading and adjust the font sizes there. The handler expects a ggplot, a grob, or a gTree, otherwise throws an error. The association module puts several plots together and they come out as a gTree. I honestly don't know if these size adjustments are reflected in report cards.

I think (and I am probably at least a little off) the issue is the plot output is set to 100% width of the widget and the sliders in plot_with_settings control just that - the size of the widgets. The plot then gets stretched or shrunk to fill that size but since the font sizes are in no way tied to the plot dimensions, they can become very small or very large compared to the plot size.

Now, @nikolas-burkoff, I didn't even get to plot_vars_summary. It seems to me that the ggplot object is converted to a grob before being displayed.

I also fail to see how to apply ggplot2_args. The help page (teal.widgets::ggplot2_args) is not very helpful.

@lcd2yyz Keep in mind that different text elements have different font sizes, e.g. axis labels are larger than tick labels. Strictly speaking, a font size slider would have to be applied to every one of those, which would be terrible to use. I would sooner see a font scaling slider, sort of a cex analog.