Skip to content

523 bugfix categorical var@main #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 22, 2023
Merged

523 bugfix categorical var@main #524

merged 9 commits into from
May 22, 2023

Conversation

BLAZEWIM
Copy link
Contributor

Pull Request

Fixes #523

@BLAZEWIM BLAZEWIM added the core label Apr 19, 2023
@BLAZEWIM BLAZEWIM self-assigned this Apr 19, 2023
chlebowa
chlebowa reviewed May 8, 2023
View reviewed changes
R/tm_outliers.R Outdated
if (!is.null(othervalue)) {
if (identical(othervalue, value))
"`Variable` and `Categorical factor` cannot be the same"
if (other %in% names(selector_list())){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a fan of this, I don't think it should be necessary. I will try to find another way.

@chlebowa chlebowa assigned chlebowa and unassigned BLAZEWIM May 9, 2023
@chlebowa chlebowa marked this pull request as ready for review May 17, 2023 08:38
@chlebowa chlebowa requested a review from a team May 17, 2023 08:39
@chlebowa chlebowa removed their assignment May 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2023 •
edited
Loading

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ----------------------------------------------
R/tm_a_pca.R                    821     821  0.00%    73-1019
R/tm_a_regression.R             710     710  0.00%    93-887
R/tm_data_table.R               171     171  0.00%    59-282
R/tm_file_viewer.R              172     172  0.00%    39-241
R/tm_front_page.R               127     116  8.66%    64-206
R/tm_g_association.R            327     327  0.00%    90-476
R/tm_g_bivariate.R              649     489  24.65%   125-700, 748, 754, 758, 869, 886, 904, 924-946
R/tm_g_distribution.R          1025    1025  0.00%    111-1258
R/tm_g_response.R               346     346  0.00%    86-496
R/tm_g_scatterplot.R            712     712  0.00%    143-946
R/tm_g_scatterplotmatrix.R      278     259  6.83%    79-374, 428, 442
R/tm_missing_data.R            1034    1034  0.00%    59-1229
R/tm_outliers.R                 944     944  0.00%    77-1143
R/tm_t_crosstable.R             251     251  0.00%    82-371
R/tm_variable_browser.R         815     810  0.61%    62-1294
R/utils.R                       122     122  0.00%    74-352
R/zzz.R                           1       1  0.00%    2
TOTAL                          8505    8310  2.29%

Diff against main

Filename           Stmts    Miss  Cover
---------------  -------  ------  --------
R/tm_outliers.R       +4      +4  +100.00%
TOTAL                 +4      +4  -0.00%

Results for commit: ad660d7

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

Unit Tests Summary

  1 files    5 suites   0s ⏱️
16 tests 16 ✔️ 0 💤 0 ❌
49 runs  49 ✔️ 0 💤 0 ❌

Results for commit 42f19ea.

@chlebowa chlebowa requested a review from asbates May 18, 2023 14:11
@chlebowa chlebowa merged commit 48f168b into main May 22, 2023
@chlebowa chlebowa deleted the 523_bugfix_categorical_var@main branch May 22, 2023 06:42
@chlebowa chlebowa mentioned this pull request May 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@chlebowa chlebowa chlebowa left review comments

@asbates asbates asbates approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BLAZEWIM @asbates @chlebowa