Skip to content

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Jun 16, 2023

The follow-up after https://github.com/insightsengineering/coredev-tasks/issues/235

Final spelling::spell_check_package()

  WORD              FOUND IN
facetting         add_facet_labels.Rd:5,22
                  tm_g_bivariate.Rd:43,46
                  NEWS.md:167,183
Forkers           README.md:57
pre               tm_t_crosstable.Rd:22,27
repo              README.md:9,15,56,57
reproducibility   NEWS.md:269
tabset            establish_updating_selection.Rd:20,23
                  render_single_tab.Rd:5,33
                  render_tab_header.Rd:5,17
                  render_tab_table.Rd:5
TLG               README.md:34

@m7pr m7pr added documentation Improvements or additions to documentation core labels Jun 16, 2023
@m7pr m7pr requested a review from pawelru June 16, 2023 08:07
@m7pr m7pr self-assigned this Jun 16, 2023
@m7pr m7pr mentioned this pull request Jun 16, 2023
6 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2023

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ----------------------------------------------
R/tm_a_pca.R                    821     821  0.00%    73-1019
R/tm_a_regression.R             710     710  0.00%    93-887
R/tm_data_table.R               171     171  0.00%    59-282
R/tm_file_viewer.R              172     172  0.00%    39-241
R/tm_front_page.R               127     116  8.66%    64-206
R/tm_g_association.R            327     327  0.00%    90-476
R/tm_g_bivariate.R              652     492  24.54%   125-703, 751, 757, 761, 872, 889, 907, 927-949
R/tm_g_distribution.R          1025    1025  0.00%    111-1258
R/tm_g_response.R               346     346  0.00%    86-496
R/tm_g_scatterplot.R            712     712  0.00%    143-946
R/tm_g_scatterplotmatrix.R      278     259  6.83%    79-374, 428, 442
R/tm_missing_data.R            1034    1034  0.00%    59-1229
R/tm_outliers.R                 944     944  0.00%    77-1143
R/tm_t_crosstable.R             251     251  0.00%    82-371
R/tm_variable_browser.R         815     810  0.61%    62-1294
R/utils.R                       122     122  0.00%    74-352
R/zzz.R                           1       1  0.00%    2
TOTAL                          8508    8313  2.29%

Diff against main

Filename              Stmts    Miss  Cover
------------------  -------  ------  -------
R/tm_g_bivariate.R       +3      +3  -0.11%
TOTAL                    +3      +3  -0.00%

Results for commit: 6d3ec2c

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@m7pr
Copy link
Contributor Author

m7pr commented Jun 18, 2023

Hey @cicdguy are you able to have a look in here in checks? I am awaiting for the R CMD CHECK in here since two days. I even triggered it manually https://github.com/insightsengineering/teal.modules.general/actions/runs/5304774943 but it is not visible here on PR and I can not merge changes in this PR

@cicdguy
Copy link
Contributor

cicdguy commented Jun 18, 2023

See how the GHA bot restyled your files automatically for you? GHA workflow runs are skipped if commits are made by the bot. This is done in order to protect recursion caused by auto-commits. Both, GitHub themselves and we (IDR) enforce this.

To fix this, push an empty commit to retrigger the workflows.

And no - there is no workaround or solution to this issue.

@m7pr
Copy link
Contributor Author

m7pr commented Jun 19, 2023

no worries @cicdguy thanks! I actually had the same idea that empty commit can do the trick

@github-actions
Copy link
Contributor

Unit Tests Summary

  1 files    5 suites   0s ⏱️
16 tests 16 ✔️ 0 💤 0
49 runs  49 ✔️ 0 💤 0

Results for commit fc9ec85.

@m7pr m7pr merged commit 8e2fe39 into main Jun 19, 2023
@m7pr m7pr deleted the update_wordlist@main branch June 19, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants