Skip to content

Conversation

vedhav
Copy link
Contributor

@vedhav vedhav commented Nov 9, 2023

Closes #591 and also use the new join_keys functions and methods part of the teal.data PR #184

Copy link
Contributor

github-actions bot commented Nov 9, 2023

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ----------------------------------------------
R/tm_a_pca.R                    829     829  0.00%    72-1025
R/tm_a_regression.R             716     716  0.00%    96-895
R/tm_data_table.R               171     171  0.00%    62-285
R/tm_file_viewer.R              172     172  0.00%    42-244
R/tm_front_page.R               127     116  8.66%    65-207
R/tm_g_association.R            333     333  0.00%    92-483
R/tm_g_bivariate.R              655     495  24.43%   128-709, 757, 763, 767, 878, 895, 913, 933-955
R/tm_g_distribution.R          1028    1028  0.00%    122-1272
R/tm_g_response.R               349     349  0.00%    88-501
R/tm_g_scatterplot.R            719     719  0.00%    163-973
R/tm_g_scatterplotmatrix.R      280     261  6.79%    80-377, 431, 445
R/tm_missing_data.R            1044    1044  0.00%    60-1241
R/tm_outliers.R                 976     976  0.00%    78-1183
R/tm_t_crosstable.R             254     254  0.00%    83-375
R/tm_variable_browser.R         833     828  0.60%    63-1327
R/utils.R                       122     122  0.00%    74-351
R/zzz.R                           1       1  0.00%    2
TOTAL                          8609    8414  2.27%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: c769c01

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Nov 9, 2023

Unit Tests Summary

  1 files    5 suites   0s ⏱️
16 tests 16 ✔️ 0 💤 0
49 runs  49 ✔️ 0 💤 0

Results for commit c769c01.

♻️ This comment has been updated with latest results.

@m7pr m7pr added the core label Nov 9, 2023
@vedhav vedhav force-pushed the 591-migrate-to-teal_data@78_simplify_joinkeys@main branch from 8e453c0 to efe3e2c Compare November 15, 2023 10:39
Copy link
Contributor

@kartikeyakirar kartikeyakirar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Not needed for getters but it's nice to use the same getters too
@vedhav vedhav merged commit 5b30c02 into main Nov 20, 2023
@vedhav vedhav deleted the 591-migrate-to-teal_data@78_simplify_joinkeys@main branch November 20, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace TealData with teal_data in the docs

4 participants