Conversation
Generated by 🚫 Danger |
|
@TimOliver has imported this pull request. If you are a Meta employee, you can view this in D85658369. |
|
@TimOliver merged this pull request in c7de5ef. |
TimOliver
added a commit
that referenced
this pull request
Dec 10, 2025
Summary: I noticed that in the latest commit to main, [the build had started failing](https://github.com/Instagram/IGListKit/actions/runs/18856759807/job/53806413365). Looking into it, it seems GitHub has removed `iOS 26.0` as a valid destination, replacing it with both `iOS 26.0.1` and `iOS 26.1` on their `macos-26` runner target. I tried removing the explicit iOS version define in the CI YAML file, but unfortunately, this ended up breaking the UI test target. It turns out that one requires the 'preboot' step in order to work, and without an OS number, the preboot, and xcodebuild steps both arbitrarily choose different simulator slices to execute. :( On top of that, when I fixed this issue and tried to do a fresh build, `IGSectionMap` was throwing a build error in one of the IGAsserts, requiring that the provided `NSUInteger` needed to be typecast to `(unsigned int)`. So, in order to fix this moving forward, I went back to macos-14, since we're pretty safe in that iOS 18's build numbers probably won't be updated in that one for a fair while. Pull Request resolved: #1643 Test Plan: I confirmed the external tests pass, so as long as the internal ones pass too, we should be good! Reviewed By: m3rlin45 Differential Revision: D85658369 Pulled By: TimOliver fbshipit-source-id: 78cc0f9d9e9e095bb99c010d844d2186be0017f6
TimOliver
added a commit
that referenced
this pull request
Dec 10, 2025
Summary: I noticed that in the latest commit to main, [the build had started failing](https://github.com/Instagram/IGListKit/actions/runs/18856759807/job/53806413365). Looking into it, it seems GitHub has removed `iOS 26.0` as a valid destination, replacing it with both `iOS 26.0.1` and `iOS 26.1` on their `macos-26` runner target. I tried removing the explicit iOS version define in the CI YAML file, but unfortunately, this ended up breaking the UI test target. It turns out that one requires the 'preboot' step in order to work, and without an OS number, the preboot, and xcodebuild steps both arbitrarily choose different simulator slices to execute. :( On top of that, when I fixed this issue and tried to do a fresh build, `IGSectionMap` was throwing a build error in one of the IGAsserts, requiring that the provided `NSUInteger` needed to be typecast to `(unsigned int)`. So, in order to fix this moving forward, I went back to macos-14, since we're pretty safe in that iOS 18's build numbers probably won't be updated in that one for a fair while. Pull Request resolved: #1643 Test Plan: I confirmed the external tests pass, so as long as the internal ones pass too, we should be good! Reviewed By: m3rlin45 Differential Revision: D85658369 Pulled By: TimOliver fbshipit-source-id: 78cc0f9d9e9e095bb99c010d844d2186be0017f6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that in the latest commit to main, the build had started failing.
Looking into it, it seems GitHub has removed
iOS 26.0as a valid destination, replacing it with bothiOS 26.0.1andiOS 26.1.To try and make this more resilient, I've removed the direct simulator version now. The main reason why I was explicitly defining versions was to ensure that for the pipelines that reference the simulator in different build steps, the same simulator would be guaranteed to be called. HOPEFULLY this was just being over-the-top and isn't actually needed.
On top of that, when I fixed this issue and tried to do a fresh build,
IGSectionMapwas throwing a build error in one of the IGAsserts, requiring that the providedNSUIntegerneeded to be typecast to(unsigned int).Hopefully with these two issues, the build should be fixed.