Skip to content

Syntax warning and deprecation warning in Python 3.8 #215

@tirkarthi

Description

@tirkarthi

Syntax warning due to comparison of literals using is where == or != should be used. Deprecation warnings are raised due to invalid escape sequences in Python 3.8 . Below is a log of the warnings raised during compiling all the python files. Using raw strings or escaping them will fix this issue.

 find . -iname '*.py'  | xargs -P 4 -I{} python -Wall -m py_compile {} 

./instana/util.py:230: DeprecationWarning: invalid escape sequence \s
  regexp_sql_values = re.compile('(\'[\s\S][^\']*\'|\d*\.\d+|\d+|NULL)')
./instana/util.py:283: DeprecationWarning: invalid escape sequence \.
  regexp_py = re.compile('\.py$')
./instana/util.py:19: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if sys.version_info.major is 2:
./instana/util.py:250: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if hip is not None and len(hip) is 8:
./instana/instrumentation/urllib3.py:21: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if args is not None and len(args) is 2:
./instana/instrumentation/urllib3.py:34: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if len(parts) is 2:
./instana/instrumentation/aiohttp/server.py:47: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if ec is 0:
./instana/instrumentation/django/middleware.py:58: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if ec is 0:
./instana/instrumentation/flask/vanilla.py:69: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if ec is 0:
./instana/instrumentation/flask/with_blinker.py:67: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if ec is 0:
./instana/instrumentation/sqlalchemy.py:13: DeprecationWarning: invalid escape sequence \/
  url_regexp = re.compile('\/\/(\S+@)')
./instana/instrumentation/tornado/server.py:82: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if ec is 0:
./instana/meter.py:191: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if self.agent.machine.fsm.current is "wait4init":
./instana/meter.py:194: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if self.agent.machine.fsm.current is not "good2go":
./instana/meter.py:219: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if response.status_code is 200 and len(response.content) > 2:
./instana/agent.py:164: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if response.status_code is 200:
./instana/agent.py:178: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if response.status_code is 200:
./instana/agent.py:197: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if response.status_code is 200:
./instana/agent.py:222: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if response.status_code is 200:
./instana/fsm.py:159: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if response and (response.status_code is 200) and (len(response.content) > 2):
./instana/tracer.py:157: DeprecationWarning: invalid escape sequence \.
  re_tracer_frame = re.compile('/instana/.*\.py$')
./tests/test_id_management.py:8: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if sys.version_info.major is 2:
./tests/test_secrets.py:87: DeprecationWarning: invalid escape sequence \d
  kwlist = ['\d']
./tests/test_secrets.py:97: DeprecationWarning: invalid escape sequence \d
  kwlist = ['\d\d\d']

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions