Skip to content

Support Path Templates #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2018
Merged

Support Path Templates #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions instana/json_span.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ class HttpData(object):
url = None
status = 0
method = None
path_tpl = None
error = None

def __init__(self, **kwds):
Expand Down
5 changes: 3 additions & 2 deletions instana/recorder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,10 @@ def build_registered_span(self, span):

if span.operation_name in self.http_spans:
data.http = HttpData(host=self.get_http_host_name(span),
url=span.tags.pop(ext.HTTP_URL, ""),
method=span.tags.pop(ext.HTTP_METHOD, ""),
url=span.tags.pop(ext.HTTP_URL, None),
method=span.tags.pop(ext.HTTP_METHOD, None),
status=span.tags.pop(ext.HTTP_STATUS_CODE, None),
path_tpl=span.tags.pop("http.path_tpl", None),
error=span.tags.pop('http.error', None))

if span.operation_name == "rabbitmq":
Expand Down