Fix for issue 172 #173
Closed
Fix for issue 172 #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
New commit should ensure span is closed or left open if there is a downstream handler defined. |
Contributor
Author
|
I think that perhaps the wrapper around handle_user_exception should create a log span so that the error message gets picked up under Log Messages in the UI. WDYT? |
Contributor
Author
|
Any update on this? |
Contributor
|
Hi Steve - this probably won't progress until after August 1. Your use of |
Contributor
Author
|
Peter, Any chance you have time to dig into this and review it? |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leave the scope open for downstream error handles and logging instrumentation.