AIOHTTP: Don't count successful responses as errors #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbelyeu
commented
Aug 20, 2020
so they are not input as errors
bbelyeu
commented
Aug 20, 2020
| except aiohttp.web.HTTPException as e: | ||
| # AIOHTTP uses exceptions for specific responses | ||
| # see https://docs.aiohttp.org/en/latest/web_exceptions.html#web-server-exceptions | ||
| response = e |
Contributor
Author
There was a problem hiding this comment.
In AIOHTTP their exception objects have the status & headers attributes just like the response objects (same interface) so this shouldn't break the lines below. https://docs.aiohttp.org/en/latest/web_exceptions.html#base-http-exception
Contributor
|
Thanks @bbelyeu - excellent contrib. |
pglombardo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AIOHTTP uses some exceptions to indicate successful responses. We frequently use this for 204 / No Content APIs.
These 204s are currently showing in Instana as "Erroneous Calls", but they aren't our APIs perspective.
See https://docs.aiohttp.org/en/latest/web_exceptions.html#successful-exceptions