Add support for API Gateway v2 Lambda payload #288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pglombardo
reviewed
Nov 20, 2020
Contributor
pglombardo
left a comment
pglombardo
left a comment
There was a problem hiding this comment.
This is a great improvement - thanks
| is_application_load_balancer_trigger(event) | ||
|
|
||
| if is_proxy_event: | ||
| return tracer.extract('http_headers', event['headers']) |
Contributor
There was a problem hiding this comment.
The failsafe check here would be to also add in if "headers" in event or alternatively wrap this entire function in an try..except (or both). What do you think?
Author
There was a problem hiding this comment.
Fair enough, although the fact that this is a proxy event guarantees that we have headers. Who knows when AWS decides to change their payload again. An event.get('headers', dict()) maybe?
| return True | ||
|
|
||
|
|
||
| def is_api_gateway_v2_proxy_trigger(event): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS has introduced a new trigger event type, which is now a default for newly created triggers. This PR adds support for such payload format, extracting the trace context and necessary tags for the entry span.