Do not mark Django HTTP 404 response spans as errors #294
+34
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manojpandey
reviewed
Feb 23, 2021
manojpandey
approved these changes
Feb 23, 2021
Contributor
manojpandey
left a comment
manojpandey
left a comment
There was a problem hiding this comment.
LGTM, except a small minor comment.
manojpandey
approved these changes
Feb 26, 2021
andrewslotin
force-pushed
the
dont_report_django_http404_as_error
branch
from
4eaab87 to
b3b2303
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Django instrumentation to not to count
django.http.response.Http404exceptions as errors. This is a perfectly normal case for an app to signal that the requested document is not found, hence it should not be reported as an error.