Skip to content

not setting the path_tpl at all when it evaluates to None #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2021
Merged

not setting the path_tpl at all when it evaluates to None #320

merged 1 commit into from
May 31, 2021

Conversation

@pdimitra
Copy link
Contributor

@pdimitra pdimitra commented May 31, 2021 •
edited
Loading

This is the only change asked by Cedric, can go with any other future release

@pdimitra pdimitra requested a review from manojpandey May 31, 2021 08:04
manojpandey
manojpandey approved these changes May 31, 2021
View reviewed changes
Copy link
Contributor

@manojpandey manojpandey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pdimitra pdimitra merged commit 73636a0 into master May 31, 2021
@pdimitra pdimitra deleted the sanic_omit_pathtpl_when_none branch May 31, 2021 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@manojpandey manojpandey manojpandey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pdimitra @manojpandey