W3c trace context #331
W3c trace context #331
Conversation
scorphus
left a comment
scorphus
left a comment
There was a problem hiding this comment.
Hi! 👋
Please consider my suggestions below.
andrewslotin
left a comment
andrewslotin
left a comment
There was a problem hiding this comment.
Overall LGTM. I did not check the complete flow, let's make sure it passes the compatibility test suite first :)
pdimitra
requested review from
andrewslotin and
hmadison
and removed request for
andrewslotin
hmadison
left a comment
hmadison
left a comment
There was a problem hiding this comment.
I think we need to drop Pika support untill we have a clear idea if we want to support AMQP header propagation. Outside of that, I'm happy to see this work get finished and I think making a dev0 release and testing internally should be our next steps.
Co-authored-by: Pablo Aguiar <scorphus@gmail.com>
Co-authored-by: Pablo Aguiar <scorphus@gmail.com>
Co-authored-by: Pablo Aguiar <scorphus@gmail.com>
…strumentation, right now only for ASGI
… be applied for entry spans
Co-authored-by: Hunter Madison <hmadison@users.noreply.github.com>
…race context propagators and update all instrumentations to use the right one for headers extract/inject
pdimitra
force-pushed
the
w3c-trace-context
branch
from
aa7b01c to
335e632
Compare
andrewslotin
left a comment
andrewslotin
left a comment
There was a problem hiding this comment.
LGTM implementation-wise, but I'm not sure about the introduction of new propagator formats. Would it be possible to update the existing ones?
…efining the w3c trace context propagation
andrewslotin
left a comment
andrewslotin
left a comment
There was a problem hiding this comment.
I'd suggest we make W3C trace context support opt-out instead of opt-in. Otherwise LGTM
This PR enables the forwarding and participating of the w3c trace context propagation.
The w3c trace context is going to be propagated for all HTTP requests
Additional changes occurred in this PR, are including moving the "asgi" span type from SDK to Registered.
The tracer test suite is passing all tests related to w3c trace context.