Handle X-INSTANA-L according to specifications #352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Ferenc-
commented
Mar 4, 2022
Ferenc-
commented
- Propagate X-INSTANA-L
- Only return spans if X-INSTANA-L==0
- Only propagate span_id and trace_id if X-INSTANA-L!=0
andrewslotin
suggested changes
Mar 4, 2022
andrewslotin
left a comment
andrewslotin
left a comment
There was a problem hiding this comment.
Overall LGTM, however I've put some suggestions to make the changes less error-prone
andrewslotin
reviewed
Mar 4, 2022
Ferenc-
force-pushed
the
feat/X-INSTANA-L_0
branch
from
4eb77a0 to
3fc6182
Compare
andrewslotin
approved these changes
Mar 7, 2022
andrewslotin
left a comment
andrewslotin
left a comment
There was a problem hiding this comment.
LGTM! As a suggestion I believe it might be a good time to refactor the way we populate carrier fields in HTTP propagator to reduce duplication. You might also consider using a boolean value to store the context.level for readability.
Ferenc-
force-pushed
the
feat/X-INSTANA-L_0
branch
2 times, most recently
from
3c80508 to
24b3a00
Compare
Ferenc-
force-pushed
the
feat/X-INSTANA-L_0
branch
2 times, most recently
from
34c0d38 to
d1a735a
Compare
* As stated in the changelog here: https://github.com/getsentry/responses/releases/tag/0.18.0 0.18.0 Removed internal `_matches` attribute of RequestsMock object. Which has been used by our UT TCs, so before we refactor that we need to pin the last known working version.
For skipping tracestate update in suppression mode Co-authored-by: Andrey Slotin <andrey.slotin@instana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.