Skip to content

fix: Flaky test in urllib3 #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2024
Merged

fix: Flaky test in urllib3 #600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/clients/test_urllib3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,9 @@ def test_get_request(self):
assert len(urllib3_span.stack) > 1

def test_get_request_https(self):
request_url = "https://reqres.in:443/api/users"
with tracer.start_as_current_span("test"):
r = self.http.request("GET", "https://httpbin.org/robots.txt")
r = self.http.request("GET", request_url)

spans = self.recorder.queued_spans()
assert len(spans) == 2
Expand All @@ -163,7 +164,7 @@ def test_get_request_https(self):
assert test_span.data["sdk"]["name"] == "test"
assert urllib3_span.n == "urllib3"
assert urllib3_span.data["http"]["status"] == 200
assert urllib3_span.data["http"]["url"] == "https://httpbin.org:443/robots.txt"
assert urllib3_span.data["http"]["url"] == request_url
assert urllib3_span.data["http"]["method"] == "GET"
assert urllib3_span.stack
assert isinstance(urllib3_span.stack, list)
Expand Down